From: Arjan van de Ven <arjan@infradead.org>
To: Marcel Siegert <mws@linuxtv.org>
Cc: v4l-dvb-maintainer@linuxtv.org,
"Robert P. J. Day" <rpjday@mindspring.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [v4l-dvb-maintainer] [PATCH] DVB: Delete unused header file linux/dvb/version.h.
Date: Fri, 23 Mar 2007 17:02:44 +0100 [thread overview]
Message-ID: <1174665764.1158.241.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <200703231647.53780.mws@linuxtv.org>
On Fri, 2007-03-23 at 16:47 +0100, Marcel Siegert wrote:
> On Friday 23 March 2007, Robert P. J. Day wrote:
> >
> > Delete the unreferenced header file include/linux/dvb/version.h.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> >
> NACK
> this header is unreferenced in kernel, but used for applications that compile for userspace
> to determine the api version.
btw that is something extremely evil to do. Either you have varying apis
between kernels (which is naughty, but I suppose you can go up in
capabilities) or it's fully static.
If it's dynamic, doing it compiletime is BAD. The same binaries should
run on multiple kernels after all. An ioctl or a sysfs thing or
something is a lot better than a compile time constant.
If it's entirely static exposing a "version" doesn't mean anything and
it might as well be killed...
Greetings,
Arjan van de Ven
next prev parent reply other threads:[~2007-03-23 16:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 15:32 Robert P. J. Day
2007-03-23 15:47 ` [v4l-dvb-maintainer] " Marcel Siegert
2007-03-23 15:50 ` Robert P. J. Day
2007-03-23 16:02 ` Arjan van de Ven [this message]
2007-03-23 16:18 ` Marcel Siegert
2007-03-24 12:04 ` Manu Abraham
2007-03-25 9:11 ` Arjan van de Ven
2007-03-25 12:03 ` Manu Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174665764.1158.241.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mws@linuxtv.org \
--cc=rpjday@mindspring.com \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®