From: Rusty Russell <rusty@rustcorp.com.au>
To: Matt Mackall <mpm@selenic.com>
Cc: Andi Kleen <ak@suse.de>,
akpm@linux-foundation.org, bunk@stusta.de,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Cleanup: i386 separate hardware-defined TSS from Linux additions
Date: Fri, 30 Mar 2007 15:44:31 +1000 [thread overview]
Message-ID: <1175233471.12230.371.camel@localhost.localdomain> (raw)
In-Reply-To: <20070330023355.GU10459@waste.org>
On Thu, 2007-03-29 at 21:33 -0500, Matt Mackall wrote:
> > unsigned short gs, __gsh;
> > unsigned short ldt, __ldth;
> > unsigned short trace, io_bitmap_base;
> > +} __attribute__((packed));
> > +
> > +struct tss_struct {
> > + struct i386_hw_tss x86_tss;
> > +
> > /*
> > * The extra 1 is there because the CPU will access an
> > * additional byte beyond the end of the IO permission
>
> This comment needs to stay in the first struct..?
Hi Matt!
Actually, it refers to the next field. To give complete context:
/*
* The extra 1 is there because the CPU will access an
* additional byte beyond the end of the IO permission
* bitmap. The extra byte must be all 1 bits, and must
* be within the limit.
*/
unsigned long io_bitmap[IO_BITMAP_LONGS + 1];
Cheers,
Rusty.
prev parent reply other threads:[~2007-03-30 5:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200703270607.l2R672de009090@shell0.pdx.osdl.net>
[not found] ` <200703291219.47276.ak@suse.de>
[not found] ` <1175165905.12230.201.camel@localhost.localdomain>
[not found] ` <200703291316.56393.ak@suse.de>
2007-03-30 2:36 ` Rusty Russell
2007-03-30 2:33 ` Matt Mackall
2007-03-30 5:44 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175233471.12230.371.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®