From: Jan Glauber <jang@linux.vnet.ibm.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Thomas Backlund <tmb@mandriva.org>, linux-kernel@vger.kernel.org
Subject: Re: Why is arch/s390/crypto/Kconfig sourced when building for another arch ?
Date: Fri, 30 Mar 2007 16:20:09 +0000 [thread overview]
Message-ID: <1175271610.5474.30.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0703300551460.10946@CPE00045a9c397f-CM001225dbafb6>
On Fri, 2007-03-30 at 05:55 -0400, Robert P. J. Day wrote:
> i'm betting the S390 folks would *really* hate that idea but, if you
> look closely, the generic Kconfig file *already* has some
> arch-dependent content:
>
> ...
> config CRYPTO_DEV_PADLOCK
> tristate "Support for VIA PadLock ACE"
> depends on X86_32 <-----
> ...
Yes, but the padlock driver is located under drivers/crypto. The s390
crypto stuff is not. It is under arch/s390/crypto, thats why the Kconfig
file is there...
Both solutions (the current and your proposed) are somehow ugly.
I don't care too much, where the Kconfig entries are, as long as it
works. So if you're interested in changing it go forward and post a
patch...
Jan
> i think it's a matter of deciding how to be consistent. either you
> allow individual architectures to define their own additional Kconfig
> files or you don't. mixing the two approaches is a recipe for
> confusion.
>
> rday
>
>
next prev parent reply other threads:[~2007-03-30 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-28 19:36 Thomas Backlund
2007-03-30 9:30 ` Jan Glauber
2007-03-30 9:55 ` Robert P. J. Day
2007-03-30 16:20 ` Jan Glauber [this message]
2007-03-30 22:15 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175271610.5474.30.camel@localhost.localdomain \
--to=jang@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
--cc=tmb@mandriva.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®