From: James Bottomley <James.Bottomley@SteelEye.com>
To: Ed Lin <ed.lin@promise.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
jeff <jeff@garzik.org>, promise_linux <promise_linux@promise.com>
Subject: Re: [PATCH 3/4] [SCSI]stex: fix reset recovery for console device
Date: Sat, 31 Mar 2007 13:46:27 -0500 [thread overview]
Message-ID: <1175366787.3760.68.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <NONAMEB98KtdhQYZkxO000005d5@nonameb.ptu.promise.com>
On Fri, 2007-03-30 at 15:21 -0700, Ed Lin wrote:
> After reset completed, the scsi error handler sends out START_STOP
> and TEST_UNIT_READY to the device. For 'normal' devices these
> commands will be handled by firmware. However, because the RAID
> console only interfaces to scsi mid layer, the firmware will not process
> these commands for it. This will make the console to be offlined right
> after reset. Add the handling in driver to fix this problem.
I don't see how this explanation can be correct. The error handler only
sends a START_STOP command if sdev->allow_restart is one, which you have
to set in the slave_configure routines (which stex doesn't). If you're
seeing a START_STOP in the eh path, there's something else wrong.
TEST_UNIT_READY, certainly ... it's part of a restart check.
James
next prev parent reply other threads:[~2007-03-31 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 22:21 Ed Lin
2007-03-31 18:46 ` James Bottomley [this message]
2007-04-02 18:14 Ed Lin
2007-04-02 18:27 ` James Bottomley
2007-04-02 23:01 Ed Lin
2007-04-04 17:31 Ed Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175366787.3760.68.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=ed.lin@promise.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=promise_linux@promise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®