Re: [PATCH v2] ACPI / LPSS: add lpss device for Wildcat Point PCH

["Rafael J. Wysocki" <rjw@rjwysocki.net>]

On Friday, August 01, 2014 09:06:35 AM Jie Yang wrote:
> INT3438 is the ADSP device on Wildcat Point platform
> with 2 DW DMA engines built In. The DMA engines are
> used for DSP FW loading and audio data transferring.
> These DMA engine probing need the clock, without it,
> probing may failed and can't go forward.
> 
> Add lpss device "INT3438" for Wildcat Point PCH, to
> provide clock for its ADSP DMA engine probing.
> 
> Signed-off-by: Jie Yang <yang.jie@intel.com>

Looks good, queued up for 3.17, thanks!

> ---
>  drivers/acpi/acpi_lpss.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index 9cb65b0..ce06149 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -113,6 +113,14 @@ static void lpss_i2c_setup(struct lpss_private_data *pdata)
>  	writel(val, pdata->mmio_base + offset);
>  }
>  
> +static struct lpss_device_desc wpt_dev_desc = {
> +	.clk_required = true,
> +	.prv_offset = 0x800,
> +	.ltr_required = true,
> +	.clk_divider = true,
> +	.clk_gate = true,
> +};
> +
>  static struct lpss_device_desc lpt_dev_desc = {
>  	.clk_required = true,
>  	.prv_offset = 0x800,
> @@ -226,6 +234,8 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
>  	{ "INT3436", LPSS_ADDR(lpt_sdio_dev_desc) },
>  	{ "INT3437", },
>  
> +	{ "INT3438", LPSS_ADDR(wpt_dev_desc) },
> +
>  	{ }
>  };
>  
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.