From: Daniel Walker <dwalker@mvista.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: real time hang w/ latency tracing
Date: Wed, 04 Apr 2007 08:36:53 -0700 [thread overview]
Message-ID: <1175701013.15973.8.camel@imap.mvista.com> (raw)
In-Reply-To: <20070404085133.GC2521@elte.hu>
On Wed, 2007-04-04 at 10:51 +0200, Ingo Molnar wrote:
> * Daniel Walker <dwalker@mvista.com> wrote:
>
> > Index: linux-2.6.20/include/linux/serial_core.h
> > ===================================================================
> > --- linux-2.6.20.orig/include/linux/serial_core.h
> > +++ linux-2.6.20/include/linux/serial_core.h
> > @@ -213,7 +213,11 @@ struct uart_icount {
> > typedef unsigned int __bitwise__ upf_t;
> >
> > struct uart_port {
> > +#ifdef CONFIG_LATENCY_TIMING
> > + raw_spinlock_t lock; /* port lock */
> > +#else
> > spinlock_t lock; /* port lock */
> > +#endif
>
> ugh - this will only cause other problems if anyone else is trying to
> use the serial code. This needs a cleaner fix - such as not doing that
> printk from atomic context.
I assumed this fix wasn't totally right .. Interrupts could be enabled
just before printing , after any critical stuff has happened then
disabled again after printing .. Or are you thinking of something more
complex?
Daniel
next prev parent reply other threads:[~2007-04-04 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-03 18:57 Daniel Walker
2007-04-04 1:41 ` Daniel Walker
2007-04-04 8:51 ` Ingo Molnar
2007-04-04 15:36 ` Daniel Walker [this message]
2007-04-04 15:42 ` Ingo Molnar
2007-04-04 15:57 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175701013.15973.8.camel@imap.mvista.com \
--to=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®