mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	tglx@linutronix.de, johnstul@us.ibm.com,
	LKML <linux-kernel@vger.kernel.org>,
	heiko.carstens@de.ibm.com
Subject: Re: + clocksource-driver-initialize-list-value.patch added to -mm tree
Date: Thu, 05 Apr 2007 04:35:15 -0700	[thread overview]
Message-ID: <1175772915.15973.125.camel@imap.mvista.com> (raw)
In-Reply-To: <20070405075101.GA14199@elte.hu>

On Thu, 2007-04-05 at 09:51 +0200, Ingo Molnar wrote:
> * Daniel Walker <dwalker@mvista.com> wrote:
> 
> > [...] Adding a list initializer doesn't change anything..
> 
> Daniel, you are still in denial. OF COURSE it changes something: it adds 
> a line of code to a driver, where that line was not needed before. 
> That's against the fundamental task of a driver model: TO KEEP THINGS 
> SIMPLE. Yes, this concept includes single-line changes as well.

If that's a fundemental rule then we need to expand our horizons to
something a little more flexible .. I understand what your saying, I do,
but it doesn't apply to this change or clocksources . The reason I think
that is because the potential is ~100 drivers or less, once you reach a
critical mass of drivers there's few if any to be added .. So from my
perspective there no reason to overly simplify the structure..

Daniel


  reply	other threads:[~2007-04-05 11:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200704010523.l315NXJP004063@shell0.pdx.osdl.net>
2007-04-01  8:43 ` Thomas Gleixner
2007-04-04 16:38   ` Daniel Walker
2007-04-04 19:58     ` Andrew Morton
2007-04-04 20:10       ` Daniel Walker
2007-04-04 20:36         ` Ingo Molnar
2007-04-04 20:44           ` Daniel Walker
2007-04-04 21:15             ` Ingo Molnar
2007-04-04 21:30               ` Daniel Walker
2007-04-04 21:34                 ` Ingo Molnar
2007-04-04 21:59                   ` Daniel Walker
2007-04-04 23:48                     ` Jeremy Fitzhardinge
2007-04-05  0:00                       ` Daniel Walker
2007-04-05  0:20                         ` Jeremy Fitzhardinge
2007-04-05  0:34                           ` Daniel Walker
2007-04-05  6:02                             ` Thomas Gleixner
2007-04-05  7:51                             ` Ingo Molnar
2007-04-05 11:35                               ` Daniel Walker [this message]
2007-04-04 20:48           ` Andrew Morton
2007-04-04 21:47             ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175772915.15973.125.camel@imap.mvista.com \
    --to=dwalker@mvista.com \
    --cc=akpm@linux-foundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jeremy@goop.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®