From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767498AbXDFCYk (ORCPT ); Thu, 5 Apr 2007 22:24:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1767504AbXDFCYk (ORCPT ); Thu, 5 Apr 2007 22:24:40 -0400 Received: from ozlabs.org ([203.10.76.45]:43049 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1767498AbXDFCYj (ORCPT ); Thu, 5 Apr 2007 22:24:39 -0400 Subject: Re: [PATCH] Define EFLAGS_IF From: Rusty Russell To: "H. Peter Anvin" Cc: Andi Kleen , Jeremy Fitzhardinge , virtualization , Andrew Morton , lkml - Kernel Mailing List In-Reply-To: <46159D08.9030400@zytor.com> References: <1174533374.2713.104.camel@localhost.localdomain> <46159256.1040705@zytor.com> <461592AA.4060103@goop.org> <46159480.20108@zytor.com> <20070406004839.GA27668@one.firstfloor.org> <46159D08.9030400@zytor.com> Content-Type: text/plain Date: Fri, 06 Apr 2007 12:24:08 +1000 Message-Id: <1175826248.12230.668.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2007-04-05 at 18:06 -0700, H. Peter Anvin wrote: > Andi Kleen wrote: > > > > No processor.h is such a hodgepodge of unrelated stuff that any > > splitting up is a good thing. > > > > Fair enough. However, I'd still like to see the X86_CR* constants > moved, too (and constants added for at least CR0 as well.) Agreed. This was on theory of minimum damage, but since it seems to have received a warm reception, I'd say moving the rest to processor-flags.h would be a welcome addition. Cheers, Rusty.