From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932778AbXDFWRa (ORCPT ); Fri, 6 Apr 2007 18:17:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933175AbXDFWRa (ORCPT ); Fri, 6 Apr 2007 18:17:30 -0400 Received: from www.osadl.org ([213.239.205.134]:42440 "EHLO mail.tglx.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932778AbXDFWR3 (ORCPT ); Fri, 6 Apr 2007 18:17:29 -0400 Subject: Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!) From: Thomas Gleixner Reply-To: tglx@linutronix.de To: David Brownell Cc: Stefan Richter , Jan Engelhardt , Randy Dunlap , Tony Lindgren , linux-kernel@vger.kernel.org In-Reply-To: <200704061405.50169.david-b@pacbell.net> References: <11757099691323-git-send-email-tony@atomide.com> <200704061029.55710.david-b@pacbell.net> <46169968.2050006@s5r6.in-berlin.de> <200704061405.50169.david-b@pacbell.net> Content-Type: text/plain Date: Sat, 07 Apr 2007 00:17:56 +0200 Message-Id: <1175897876.28263.490.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org David, On Fri, 2007-04-06 at 14:05 -0700, David Brownell wrote: > Please change your coding style to conform to Documentation/CodingStyle. > > *** Only indent with tabs!! *** > > Every one of those examples violates that simple rule. > > Why does *anyone* have even the slightest difficulty understanding such a > simple rule? I realize that two of those words have more than a single > syllable, but that should not be a problem. Even EMACS is trainable. please stop to be more Catholic than the Pope. commit 0aa599c5644fddd3052433c5335260108a8a39a2 drivers/usb/net/usbnet.h http://tglx.de/private/tglx/usbnet.png /me recommends emacs-develock.el for colorful white space wreckage display ! You probably want to look at more files contributed by david-b before you look at mine :) tglx