mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nigel Cunningham <nigel@nigel.suspend2.net>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Pavel Machek <pavel@ucw.cz>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH -mm] swsusp: Use rbtree for tracking allocated swap
Date: Tue, 10 Apr 2007 07:00:52 +1000	[thread overview]
Message-ID: <1176152452.10245.42.camel@nigel.suspend2.net> (raw)
In-Reply-To: <200704091503.57424.rjw@sisk.pl>

Hi.

On Mon, 2007-04-09 at 15:03 +0200, Rafael J. Wysocki wrote:
> On Sunday, 8 April 2007 23:07, Nigel Cunningham wrote:
> [--snip--]
> > > > Normal usage in both cases is simply iterating through the list, so I
> > > > guess the cost would be approximately the same.
> > > > 
> > > > Deletion could would include rebalancing for the rb_nodes.
> > > 
> > > In swsusp the deletions are needed only if there's an error.
> > 
> > When freeing swap at the end of the cycle?
> 
> That depends on what you mean by 'the end'. :-)
> 
> We free swap if the image saving fails only, since it's allocated after we've
> created the image.  After the resume, the state of swap from before the image
> creation is the current one anyway.

Ah, of course. I forgot that temporarily.

Nigel


  reply	other threads:[~2007-04-09 21:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-07 21:20 Rafael J. Wysocki
2007-04-07 22:06 ` Andrew Morton
2007-04-07 22:31   ` Nigel Cunningham
2007-04-07 23:13     ` Rafael J. Wysocki
2007-04-07 23:42       ` Nigel Cunningham
2007-04-08 16:47         ` Rafael J. Wysocki
2007-04-08 21:07           ` Nigel Cunningham
2007-04-09 13:03             ` Rafael J. Wysocki
2007-04-09 21:00               ` Nigel Cunningham [this message]
2007-04-08 12:56 ` Pavel Machek
2007-04-08 17:02   ` Rafael J. Wysocki
2007-04-09 12:39     ` Pavel Machek
2007-04-10 21:00       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1176152452.10245.42.camel@nigel.suspend2.net \
    --to=nigel@nigel.suspend2.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome