From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Potin Lai <potin.lai.pt@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Patrick Williams <patrick@stwcx.xyz>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Cosmo Chou <cosmo.chou@quantatw.com>,
Potin Lai <potin.lai@quantatw.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v6 2/2] ARM: dts: aspeed: catalina: add Meta Catalina BMC
Date: Mon, 05 Aug 2024 13:22:12 +0930 [thread overview]
Message-ID: <1176b2ddb609b462004fa7e7b36fe6657b89bbf0.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240802-potin-catalina-dts-v6-2-0b8f61b80688@gmail.com>
Hi Potin,
On Fri, 2024-08-02 at 17:07 +0800, Potin Lai wrote:
> Add linux device tree entry for Meta(Facebook) Catalina compute-tray
> BMC using AT2600 SoC.
>
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Running this past checkpatch gave me the following:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Potin Lai <potin.lai.pt@gmail.com>' != 'Signed-off-by: Potin Lai <potin.lai@quantatw.com>'
If you can't send from potin.lai@quantatw.com then perhaps you could
work around this by adding a `From: ...` line as the first line of your
commit message body as documented here:
https://docs.kernel.org/process/maintainer-tip.html#ordering-of-commit-tags
Alternatively, change your S-o-B tag to potin.lai.pt@gmail.com
...
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dts
> new file mode 100644
> index 000000000000..70cec690f541
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dts
> @@ -0,0 +1,965 @@
>
...
> +&gpio0 {
> + pinctrl-names = "default";
Not sure why you need this, but I think it also causes the following
warning:
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dtb: gpio@1e780000: 'pinctrl-0' is a dependency of 'pinctrl-names'
Might be best to drop it.
Andrew
prev parent reply other threads:[~2024-08-05 3:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 9:07 [PATCH v6 0/2] Add Meta(Facebook) Catalina BMC(AST2600) Potin Lai
2024-08-02 9:07 ` [PATCH v6 1/2] dt-bindings: arm: aspeed: add Meta Catalina board Potin Lai
2024-08-02 9:07 ` [PATCH v6 2/2] ARM: dts: aspeed: catalina: add Meta Catalina BMC Potin Lai
2024-08-05 3:52 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176b2ddb609b462004fa7e7b36fe6657b89bbf0.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=cosmo.chou@quantatw.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=potin.lai.pt@gmail.com \
--cc=potin.lai@quantatw.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®