Re: [PATCH] serial: 8250: omap: Use serial8250_em485_supported

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

On Fri, 16 Sep 2022, Matthias Schiffer wrote:

> 8250_omap uses em485, fill in rs485_supported accordingly. This makes
> RS485 work with 8250_omap again, which was broken with the introduction
> of the RS485 config sanitization.
> 
> Fixes: be2e2cb1d2819 ("serial: Sanitize rs485_struct")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---

Yes, good catch. I really don't know how I managed to miss it.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.

>  drivers/tty/serial/8250/8250_omap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index ff51ff91b9237..38ee3e42251af 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -1337,6 +1337,7 @@ static int omap8250_probe(struct platform_device *pdev)
>  	up.port.throttle = omap_8250_throttle;
>  	up.port.unthrottle = omap_8250_unthrottle;
>  	up.port.rs485_config = serial8250_em485_config;
> +	up.port.rs485_supported = serial8250_em485_supported;
>  	up.rs485_start_tx = serial8250_em485_start_tx;
>  	up.rs485_stop_tx = serial8250_em485_stop_tx;
>  	up.port.has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
>