mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	 p.zabel@pengutronix.de, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	 linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v1 5/7] media: verisilicon: vp8: Use alloc/free helpers for auxiliary buffers
Date: Thu, 19 Nov 2026 17:00:16 -0500	[thread overview]
Message-ID: <117762da7f209bf873c55f974f7dc9a20967d6d0.camel@collabora.com> (raw)
In-Reply-To: <20260916125443.78602-6-benjamin.gaignard@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 2938 bytes --]

Le mercredi 16 septembre 2026 à 14:54 +0200, Benjamin Gaignard a écrit :
> Simplify and clean up the code by using the helpers.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  .../media/platform/verisilicon/hantro_vp8.c   | 37 +++++--------------
>  1 file changed, 10 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/media/platform/verisilicon/hantro_vp8.c b/drivers/media/platform/verisilicon/hantro_vp8.c
> index 381bc1d3bfda..881e6c21f0fa 100644
> --- a/drivers/media/platform/verisilicon/hantro_vp8.c
> +++ b/drivers/media/platform/verisilicon/hantro_vp8.c
> @@ -144,11 +144,9 @@ void hantro_vp8_prob_update(struct hantro_ctx *ctx,
>  
>  int hantro_vp8_dec_init(struct hantro_ctx *ctx)
>  {
> -	struct hantro_dev *vpu = ctx->dev;
>  	struct hantro_aux_buf *aux_buf;
>  	unsigned int mb_width, mb_height;
>  	size_t segment_map_size;
> -	int ret;
>  
>  	/* segment map table size calculation */
>  	mb_width = DIV_ROUND_UP(ctx->dst_fmt.width, 16);
> @@ -160,42 +158,27 @@ int hantro_vp8_dec_init(struct hantro_ctx *ctx)
>  	 * And the data in segment map buffer must be set to all zero.
>  	 */
>  	aux_buf = &ctx->vp8_dec.segment_map;
> -	aux_buf->size = segment_map_size;
> -	aux_buf->cpu = dma_alloc_coherent(vpu->dev, aux_buf->size,
> -					  &aux_buf->dma, GFP_KERNEL);
> -	if (!aux_buf->cpu)
> -		return -ENOMEM;
> +	if (hantro_allocate_aux_buf(ctx, aux_buf, segment_map_size))
> +		goto error;
>  
>  	/*
>  	 * Allocate probability table buffer,
>  	 * total 1208 bytes, 4K page is far enough.
>  	 */
>  	aux_buf = &ctx->vp8_dec.prob_tbl;
> -	aux_buf->size = sizeof(struct vp8_prob_tbl_packed);
> -	aux_buf->cpu = dma_alloc_coherent(vpu->dev, aux_buf->size,
> -					  &aux_buf->dma, GFP_KERNEL);
> -	if (!aux_buf->cpu) {
> -		ret = -ENOMEM;
> -		goto err_free_seg_map;
> -	}
> +	if (hantro_allocate_aux_buf(ctx, aux_buf, sizeof(struct vp8_prob_tbl_packed)))
> +		goto error;
>  
>  	return 0;
>  
> -err_free_seg_map:
> -	dma_free_coherent(vpu->dev, ctx->vp8_dec.segment_map.size,
> -			  ctx->vp8_dec.segment_map.cpu,
> -			  ctx->vp8_dec.segment_map.dma);
> -
> -	return ret;
> +error:
> +	hantro_free_aux_buf(ctx, &ctx->vp8_dec.segment_map);
> +	hantro_free_aux_buf(ctx, &ctx->vp8_dec.prob_tbl);
> +	return -ENOMEM;
>  }
>  
>  void hantro_vp8_dec_exit(struct hantro_ctx *ctx)
>  {
> -	struct hantro_vp8_dec_hw_ctx *vp8_dec = &ctx->vp8_dec;
> -	struct hantro_dev *vpu = ctx->dev;
> -
> -	dma_free_coherent(vpu->dev, vp8_dec->segment_map.size,
> -			  vp8_dec->segment_map.cpu, vp8_dec->segment_map.dma);
> -	dma_free_coherent(vpu->dev, vp8_dec->prob_tbl.size,
> -			  vp8_dec->prob_tbl.cpu, vp8_dec->prob_tbl.dma);
> +	hantro_free_aux_buf(ctx, &ctx->vp8_dec.segment_map);
> +	hantro_free_aux_buf(ctx, &ctx->vp8_dec.prob_tbl);
>  }

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-11-19 22:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 12:54 [PATCH v1 0/7] media: verisilicon: simplify auxiliary buffers allocation Benjamin Gaignard
2026-09-16 12:54 ` [PATCH v1 1/7] media: verisilicon: Add helpers to allocate and free auxiliary buffers Benjamin Gaignard
2026-11-19 21:58   ` Nicolas Dufresne
2026-09-16 12:54 ` [PATCH v1 2/7] media: verisilicon: AV1: Use alloc/free helpers for " Benjamin Gaignard
2026-11-19 21:59   ` Nicolas Dufresne
2026-09-16 12:54 ` [PATCH v1 3/7] media: verisilicon: h264: " Benjamin Gaignard
2026-11-19 21:59   ` Nicolas Dufresne
2026-09-16 12:54 ` [PATCH v1 4/7] media: verisilicon: hevc: " Benjamin Gaignard
2026-11-19 22:00   ` Nicolas Dufresne
2026-09-16 12:54 ` [PATCH v1 5/7] media: verisilicon: vp8: " Benjamin Gaignard
2026-11-19 22:00   ` Nicolas Dufresne [this message]
2026-09-16 12:54 ` [PATCH v1 6/7] media: verisilicon: vp9: " Benjamin Gaignard
2026-11-19 22:01   ` Nicolas Dufresne
2026-09-16 12:54 ` [PATCH v1 7/7] media: verisilicon: mpeg4: " Benjamin Gaignard
2026-11-19 22:01   ` Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=117762da7f209bf873c55f974f7dc9a20967d6d0.camel@collabora.com \
    --to=nicolas.dufresne@collabora.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®