mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: "Shan, Guo Wen (Gavin)" <gshan@alcatel-lucent.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: can a kmalloc be both GFP_ATOMIC and GFP_KERNEL at the same time?
Date: Sat, 28 Apr 2007 08:03:42 -0700	[thread overview]
Message-ID: <1177772622.3477.0.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0704281006380.25313@localhost.localdomain>


> >
> >
> >   i'd always assumed that the type flags of GFP_ATOMIC and GFP_KERNEL
> > were mutually exclusive when it came to calling kmalloc(), at least
> > based on everything i'd read.  so i'm not sure how to interpret the
> > following:
> >
> > drivers/scsi/aic7xxx_old.c:  aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_ATOMIC | GFP_KERNEL);
> > drivers/message/i2o/device.c:   resblk = kmalloc(buflen + 8, GFP_KERNEL | GFP_ATOMIC);
> >
> >   clarification?
> 
> oh, i'm *aware* of the definitions of those flags, but every single
> source i've ever read has *strongly* suggested that you don't use
> those two flags together so i was surprised to see those combinations.
> (as an example, love's kernel book, p. 192, shows a table of valid
> combinations of flags to use, but doesn't mention the one above.)
> 
> and, on the other hand, if they *are* legal to use together, i guess
> i'm kind of surprised that there would be only two instances of it.

it's not legal to use the combo; you have found yourself a very genuine
bug here! Good spotting!



  reply	other threads:[~2007-04-28 15:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-28 13:58 Shan, Guo Wen (Gavin)
2007-04-28 14:11 ` Robert P. J. Day
2007-04-28 15:03   ` Arjan van de Ven [this message]
2007-04-28 15:20     ` WANG Cong
2007-04-28 16:29   ` Alan Cox
2007-04-30  5:58     ` Christoph Lameter
  -- strict thread matches above, loose matches on Subject: below --
2007-04-28 13:40 Robert P. J. Day
2007-04-30  7:13 ` Andrew Morton
2007-04-30  8:46   ` Robert P. J. Day
2007-04-30  8:56     ` Jan Engelhardt
2007-04-30  9:52       ` Robert P. J. Day
2007-04-30 12:00         ` Satyam Sharma
2007-04-30 17:02     ` Andrew Morton
2007-04-30 17:21       ` Alan Cox
2007-04-30 19:04         ` Satyam Sharma
2007-04-30 22:42           ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1177772622.3477.0.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=gshan@alcatel-lucent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®