mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: Please revert [PATCH] user of the jiffies rounding patch: Slab
Date: Sat, 28 Apr 2007 16:40:30 -0700	[thread overview]
Message-ID: <1177803630.3477.3.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0704281632001.12695@schroedinger.engr.sgi.com>

On Sat, 2007-04-28 at 16:35 -0700, Christoph Lameter wrote:

> Hmmm... Yes but that looks like it comes from a different function. Slab
> calls
> 
>  __round_jiffies_relative(HZ, cpu))
> 
> And its description says:
> 
> /**
>  *
>  * The exact rounding is skewed for each processor to avoid all
>  * processors firing at the exact same time, which could lead
>  * to lock contention or spurious cache line bouncing.


> This is exactly the wrong thing to do.


is it?


  reply	other threads:[~2007-04-28 23:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-28 21:12 Christoph Lameter
     [not found] ` <4633D1A2.6010002@linux.intel.com>
2007-04-28 23:35   ` Christoph Lameter
2007-04-28 23:40     ` Arjan van de Ven [this message]
2007-04-30 17:43       ` Christoph Lameter
2007-04-30 19:14         ` Arjan van de Ven
2007-04-30 19:28           ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1177803630.3477.3.camel@laptopd505.fenrus.org \
    --to=arjan@linux.intel.com \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®