From: Avi Kivity <avi@qumranet.com>
To: kvm-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, Adrian Bunk <bunk@stusta.de>,
Avi Kivity <avi@qumranet.com>
Subject: [PATCH 3/7] KVM: fix an if() condition
Date: Sun, 29 Apr 2007 18:50:18 +0300 [thread overview]
Message-ID: <11778618221062-git-send-email-avi@qumranet.com> (raw)
In-Reply-To: <1177861822889-git-send-email-avi@qumranet.com>
From: Adrian Bunk <bunk@stusta.de>
It might have worked in this case since PT_PRESENT_MASK is 1, but let's
express this correctly.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Avi Kivity <avi@qumranet.com>
---
drivers/kvm/mmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c
index 32c64f6..e8e2281 100644
--- a/drivers/kvm/mmu.c
+++ b/drivers/kvm/mmu.c
@@ -1408,7 +1408,7 @@ static void audit_mappings_page(struct kvm_vcpu *vcpu, u64 page_pte,
for (i = 0; i < PT64_ENT_PER_PAGE; ++i, va += va_delta) {
u64 ent = pt[i];
- if (!ent & PT_PRESENT_MASK)
+ if (!(ent & PT_PRESENT_MASK))
continue;
va = canonicalize(va);
--
1.5.0.6
next prev parent reply other threads:[~2007-04-29 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-29 15:50 [PATCH 0/7] KVM: More 2.6.22 merge candidates Avi Kivity
2007-04-29 15:50 ` [PATCH 1/7] KVM: VMX: Properly shadow the CR0 register in the vcpu struct Avi Kivity
2007-04-29 15:50 ` [PATCH 2/7] KVM: VMX: Add lazy FPU support for VT Avi Kivity
2007-04-29 15:50 ` Avi Kivity [this message]
2007-04-29 15:50 ` [PATCH 5/7] KVM: Remove extraneous guest entry on mmio read Avi Kivity
2007-04-29 15:50 ` [PATCH 6/7] KVM: Don't require explicit indication of completion of mmio or pio Avi Kivity
2007-04-29 15:50 ` [PATCH 7/7] KVM: Remove unused 'instruction_length' Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11778618221062-git-send-email-avi@qumranet.com \
--to=avi@qumranet.com \
--cc=bunk@stusta.de \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome