From: Andrew Victor <andrew@sanpeople.com>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: akpm@linux-foundation.org, David Brownell <david-b@pacbell.net>,
Nicolas Ferre <nicolas.ferre@rfo.atmel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Use common cpu_is_xxx() macros on AT91 and AVR32
Date: 07 May 2007 12:43:13 +0200 [thread overview]
Message-ID: <1178534593.27286.28.camel@fuzzie.sanpeople.com> (raw)
In-Reply-To: <11785276841920-git-send-email-hskinnemoen@atmel.com>
> Several drivers shared between AT91 and AVR32 chips use cpu_is_xxx()
> to handle CPU-specific differences. Currently, such code needs to be
> inside #ifdef CONFIG_ARCH_AT91 because the macros don't exist on AVR32.
>
> By defining the same macros on both AT91 and AVR32, these #ifdefs can
> be eliminated. Since the macros will evaluate to a constant value for
> CPUs that aren't supported by the current architecture, any code that
> is only needed on AT91 will be optimized away on AVR32 and vice versa.
>
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
Acked-by: Andrew Victor <andrew@sanpeople.com>
prev parent reply other threads:[~2007-05-07 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 8:48 Haavard Skinnemoen
2007-05-07 8:48 ` [PATCH 2/2] atmel_spi: Remove unnecessary (and wrong) #ifdefs Haavard Skinnemoen
2007-05-07 10:43 ` Andrew Victor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178534593.27286.28.camel@fuzzie.sanpeople.com \
--to=andrew@sanpeople.com \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@rfo.atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®