mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Satyam Sharma <satyam.sharma@gmail.com>,
	chris@pcburn.com, linux-kernel@vger.kernel.org,
	bluez-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: Getting make net/built-in.o Error with 2.6.21.1 Build
Date: Tue, 08 May 2007 18:48:32 +0200	[thread overview]
Message-ID: <1178642912.8628.70.camel@aeonflux.holtmann.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0705081815130.16923@twin.jikos.cz>

Hi Jiri,

> > Sure, my aim here was to only solve the _build breakage_ by fixing the 
> > Kconfig for this module (that used code from another kernel module 
> > without listing it in its dependencies). If, as you say, the real 
> > solution is that we should actually be taking out the offending call to 
> > the other module itself, then please go ahead -- I don't know much about 
> > the Bluetooth / HIDP subsytem anyway.
> 
> Converting the hid-ff drivers to be also transport-independent is on my 
> TODO list, but it didn't happen yet.
> 
> Marcel - are you aware of any devices currently supported by USB HID 
> force-feedback code, which have a bluetooth version, please? 

I haven't looked at all details for the PS3 controller, but that might
be the first one. In theory they can and at some point they will enter
the market.

> I'd propose the patch below, until I make the usbhid force-feedback code 
> transport independent. Thanks.
> 
> 
> 
> From: Jiri Kosina <jkosina@suse.cz>
> 
> [Bluetooth] HIDP - don't initialize force feedback
> 
> The current implementation of force feedback for HID devices is 
> USB-transport only and therefore calling hid_ff_init() from hidp code is 
> not going to work (plus it creates unwanted dependency of hidp on usbhid). 
> Remove the hid_ff_init() until either the hid-ff is made 
> transport-independent, or at least support for bluetooth transport is 
> added.
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Under the condition that you remember to put it back once a generic FF
exists.

Regards

Marcel



  reply	other threads:[~2007-05-08 16:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07 23:30 Chris Bergeron
2007-05-08  0:25 ` Satyam Sharma
2007-05-08 15:49   ` Jiri Kosina
2007-05-08 16:05     ` Satyam Sharma
2007-05-08 16:23       ` Jiri Kosina
2007-05-08 16:48         ` Marcel Holtmann [this message]
2007-05-08 17:47           ` Jiri Kosina
2007-05-08 17:50             ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1178642912.8628.70.camel@aeonflux.holtmann.net \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    --cc=chris@pcburn.com \
    --cc=jikos@jikos.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=satyam.sharma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®