mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: Jens Axboe <jens.axboe@oracle.com>
Subject: [PATCH 9/19] swiotlb: sg chaining support
Date: Wed, 16 May 2007 10:32:23 +0200	[thread overview]
Message-ID: <11793043541179-git-send-email-jens.axboe@oracle.com> (raw)
In-Reply-To: <11793043533744-git-send-email-jens.axboe@oracle.com>

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
---
 lib/swiotlb.c |   19 ++++++++++++-------
 1 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index 10c13ad..1f658e4 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -673,16 +673,17 @@ swiotlb_sync_single_range_for_device(struct device *hwdev, dma_addr_t dev_addr,
  * same here.
  */
 int
-swiotlb_map_sg(struct device *hwdev, struct scatterlist *sg, int nelems,
+swiotlb_map_sg(struct device *hwdev, struct scatterlist *sgl, int nelems,
 	       int dir)
 {
+	struct scatterlist *sg;
 	void *addr;
 	dma_addr_t dev_addr;
 	int i;
 
 	BUG_ON(dir == DMA_NONE);
 
-	for (i = 0; i < nelems; i++, sg++) {
+	for_each_sg(sgl, sg, nelems, i) {
 		addr = SG_ENT_VIRT_ADDRESS(sg);
 		dev_addr = virt_to_bus(addr);
 		if (swiotlb_force || address_needs_mapping(hwdev, dev_addr)) {
@@ -692,7 +693,7 @@ swiotlb_map_sg(struct device *hwdev, struct scatterlist *sg, int nelems,
 				   to do proper error handling. */
 				swiotlb_full(hwdev, sg->length, dir, 0);
 				swiotlb_unmap_sg(hwdev, sg - i, i, dir);
-				sg[0].dma_length = 0;
+				sgl[0].dma_length = 0;
 				return 0;
 			}
 			sg->dma_address = virt_to_bus(map);
@@ -708,19 +709,21 @@ swiotlb_map_sg(struct device *hwdev, struct scatterlist *sg, int nelems,
  * concerning calls here are the same as for swiotlb_unmap_single() above.
  */
 void
-swiotlb_unmap_sg(struct device *hwdev, struct scatterlist *sg, int nelems,
+swiotlb_unmap_sg(struct device *hwdev, struct scatterlist *sgl, int nelems,
 		 int dir)
 {
+	struct scatterlist *sg;
 	int i;
 
 	BUG_ON(dir == DMA_NONE);
 
-	for (i = 0; i < nelems; i++, sg++)
+	for_each_sg(sgl, sg, nelems, i) {
 		if (sg->dma_address != SG_ENT_PHYS_ADDRESS(sg))
 			unmap_single(hwdev, bus_to_virt(sg->dma_address),
 				     sg->dma_length, dir);
 		else if (dir == DMA_FROM_DEVICE)
 			dma_mark_clean(SG_ENT_VIRT_ADDRESS(sg), sg->dma_length);
+	}
 }
 
 /*
@@ -731,19 +734,21 @@ swiotlb_unmap_sg(struct device *hwdev, struct scatterlist *sg, int nelems,
  * and usage.
  */
 static void
-swiotlb_sync_sg(struct device *hwdev, struct scatterlist *sg,
+swiotlb_sync_sg(struct device *hwdev, struct scatterlist *sgl,
 		int nelems, int dir, int target)
 {
+	struct scatterlist *sg;
 	int i;
 
 	BUG_ON(dir == DMA_NONE);
 
-	for (i = 0; i < nelems; i++, sg++)
+	for_each_sg(sgl, sg, nelems, i) {
 		if (sg->dma_address != SG_ENT_PHYS_ADDRESS(sg))
 			sync_single(hwdev, bus_to_virt(sg->dma_address),
 				    sg->dma_length, dir, target);
 		else if (dir == DMA_FROM_DEVICE)
 			dma_mark_clean(SG_ENT_VIRT_ADDRESS(sg), sg->dma_length);
+	}
 }
 
 void
-- 
1.5.2.rc1


  parent reply	other threads:[~2007-05-16  8:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-16  8:32 [PATCH 0/19] Chaining sg lists for big IO commands v6 Jens Axboe
2007-05-16  8:32 ` [PATCH 1/19] crypto: don't pollute the global namespace with sg_next() Jens Axboe
2007-05-16  8:32 ` [PATCH 2/19] Add sg helpers for iterating over a scatterlist table Jens Axboe
2007-05-16  8:32 ` [PATCH 3/19] libata: convert to using sg helpers Jens Axboe
2007-05-16  8:32 ` [PATCH 4/19] block: " Jens Axboe
2007-05-16  8:32 ` [PATCH 5/19] scsi: " Jens Axboe
2007-05-16 11:17   ` Cornelia Huck
2007-05-16 11:25     ` Jens Axboe
2007-05-16  8:32 ` [PATCH 6/19] Add chained sg support to linux/scatterlist.h Jens Axboe
2007-05-16  8:32 ` [PATCH 7/19] i386 dma_map_sg: convert to using sg helpers Jens Axboe
2007-05-16  8:32 ` [PATCH 8/19] i386: enable sg chaining Jens Axboe
2007-05-16  8:32 ` Jens Axboe [this message]
2007-05-16  8:32 ` [PATCH 10/19] x86-64: update iommu/dma mapping functions to sg helpers Jens Axboe
2007-05-16  8:32 ` [PATCH 11/19] x86-64: enable sg chaining Jens Axboe
2007-05-16  8:32 ` [PATCH 12/19] IA64: sg chaining support Jens Axboe
2007-05-16  8:32 ` [PATCH 13/19] PPC: " Jens Axboe
2007-05-16  8:32 ` [PATCH 14/19] SPARC: " Jens Axboe
2007-05-16  8:32 ` [PATCH 15/19] SPARC64: " Jens Axboe
2007-05-16  8:32 ` [PATCH 16/19] scsi: simplify scsi_free_sgtable() Jens Axboe
2007-05-16  8:32 ` [PATCH 17/19] SCSI: support for allocating large scatterlists Jens Axboe
2007-05-16  8:32 ` [PATCH 18/19] ll_rw_blk: temporarily enable max_segments tweaking Jens Axboe
2007-05-16  8:32 ` [PATCH 19/19] drivers: sg chaining support Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11793043541179-git-send-email-jens.axboe@oracle.com \
    --to=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®