mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: "Greg KH" <greg@kroah.com>, LKML <linux-kernel@vger.kernel.org>,
	"Kristian Høgsberg" <krh@bitplanet.net>
Subject: Re: Race free attributes in sysfs
Date: Mon, 21 May 2007 21:28:15 +0200	[thread overview]
Message-ID: <1179775695.3320.82.camel@lov.localdomain> (raw)
In-Reply-To: <4651E866.5010304@drzeus.cx>

On Mon, 2007-05-21 at 20:43 +0200, Pierre Ossman wrote:
> Kay Sievers wrote:
> >
> > Do you have a fixed set of attribute names, where you just want to
> > create a subset from that matches the individual device, or do you
> > need some sort of free naming for the attributes?
> 
> Currently, the names are fixed (and I don't see any pressing need for
> having dynamic names).

We could change the driver-core to suppress the creation of an attribute
if the attribute's show() or store() method returns something like
-ENOENT at registration time?
The driver would pass _all_ possible attributes of the device at
registration time, but the core would only create the attributes which
are implemented for this particular device? Would that work for you?

There are already subsystems who need to do similar things internally
(firewire), and it may be nice to add such functionality to the core.

> I do want to have the ability to add attributes
> in different parts of the code though since it allows me to group the
> sysfs stuff closer to the function it accesses.

You can assign any number of attribute groups to the device. If they
don't have a group name, they will all be created directly at the device
level. Would that work for you?

Thanks,
Kay


  reply	other threads:[~2007-05-21 19:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-20 11:01 Pierre Ossman
2007-05-21  3:12 ` Dmitry Torokhov
2007-05-21  7:47   ` Pierre Ossman
2007-05-22 21:24   ` Mark Lord
2007-05-23  2:43     ` Dmitry Torokhov
2007-05-23  4:21       ` Greg KH
2007-05-23 13:27         ` Mark Lord
2007-05-23 15:14           ` Greg KH
2007-05-26 16:12             ` Bill Davidsen
2007-05-27  8:57               ` Greg KH
2007-05-21 17:50 ` Kay Sievers
2007-05-21 18:43   ` Pierre Ossman
2007-05-21 19:28     ` Kay Sievers [this message]
2007-05-22  8:38       ` Cornelia Huck
2007-05-23  4:25         ` Greg KH
2007-05-22 15:40       ` Pierre Ossman
2007-05-22 15:58         ` Kristian Høgsberg
2007-05-22 21:25         ` Mark Lord
2007-05-23  4:24         ` Greg KH
2007-05-23  5:44           ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1179775695.3320.82.camel@lov.localdomain \
    --to=kay.sievers@vrfy.org \
    --cc=drzeus-list@drzeus.cx \
    --cc=greg@kroah.com \
    --cc=krh@bitplanet.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®