From: James Bottomley <James.Bottomley@SteelEye.com>
To: Aubrey Li <aubreylee@gmail.com>
Cc: Christoph Lameter <clameter@sgi.com>,
Bernhard Walle <bwalle@suse.de>,
linux-scsi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [scsi] Remove __GFP_DMA
Date: Wed, 23 May 2007 10:18:14 -0500 [thread overview]
Message-ID: <1179933494.3700.16.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <6d6a94c50705221941y63f4db7bj174a2265d9eaa61a@mail.gmail.com>
On Wed, 2007-05-23 at 10:41 +0800, Aubrey Li wrote:
> On 5/23/07, Christoph Lameter <clameter@sgi.com> wrote:
> > On Mon, 21 May 2007, Bernhard Walle wrote:
> >
> > > [PATCH] [scsi] Remove __GFP_DMA
> > >
> > > After 821de3a27bf33f11ec878562577c586cd5f83c64, it's not necessary to alloate a
> > > DMA buffer any more in sd.c.
> > >
> > > Signed-off-by: Bernhard Walle <bwalle@suse.de>
> >
> > Great that avoids a DMA kmalloc slab. Any other GFP_DMAs left in the scsi
> > layer?
> >
> > Acked-by: Christoph Lameter <clameter@sgi.com>
>
> Yes, here is another patch
I'll defer to Mark on this one. However, please remember that you can't
just blindly remove GFP_DMA ... there are some cards which require it.
Aacraid is one example ... it has a set of cards that can only DMA to 31
bits. For them, the GFP_DMA is necessary: The allocation in question
is a scatterlist, which must be within the device DMA mask.
James
next prev parent reply other threads:[~2007-05-23 15:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 15:15 Bernhard Walle
2007-05-22 21:44 ` Christoph Lameter
2007-05-23 2:41 ` Aubrey Li
2007-05-23 15:18 ` James Bottomley [this message]
2007-05-23 15:55 ` Robert P. J. Day
2007-05-23 16:17 ` James Bottomley
2007-05-23 19:17 ` Salyzyn, Mark
2007-05-23 19:38 ` Alan Cox
2007-05-27 19:46 ` James Bottomley
2007-05-24 13:24 ` Salyzyn, Mark
2007-05-24 14:59 ` James Bottomley
2007-05-24 17:00 ` Christoph Lameter
2007-05-24 17:15 ` James Bottomley
2007-05-24 17:22 ` Christoph Lameter
2007-05-24 17:26 ` James Bottomley
2007-05-24 16:59 ` Christoph Lameter
[not found] <fa.6bUV4KR+za7HW4tT2WBlccqvoq0@ifi.uio.no>
[not found] ` <fa.NYl60pD1cwd1ESdKNCPaOwSz1WA@ifi.uio.no>
[not found] ` <fa.hW9tQQfgwmXj0gAKQoWXOxVzpvk@ifi.uio.no>
[not found] ` <fa.xLFpJ54sTvGq6YIol2Ew31Rrq2s@ifi.uio.no>
[not found] ` <fa.JZsPKKyEKOAfxp6reMY5ZwSNjQU@ifi.uio.no>
[not found] ` <fa.txrEcCPLxIukzeVBv7UG39WubcI@ifi.uio.no>
2007-05-24 5:28 ` Robert Hancock
2007-05-24 10:08 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179933494.3700.16.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=aubreylee@gmail.com \
--cc=bwalle@suse.de \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®