From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DDE8304BB8 for ; Wed, 25 Feb 2026 22:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772058191; cv=none; b=H2p298CmiZYV1XR/aqifluOJ6g3LinCsuwfMEIvYE4LgxXVabdVUOlxZfXtTx24hgFePGK+eyXjEJvqYGQ7lzq+WTNoVLBgi6iwlUWzDJyOEMRLefUq0B1rNmGOXXMhHz0g+wOnBHEHrfwrB/mip8hOCVCvwpJXuM6Wa+oN7Jbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772058191; c=relaxed/simple; bh=9/gcaGlkQe1QrJ688U2wizDo4yOGGD0A8dLBqBOpGfc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QpnDSC9g+eBLc3YjGf/0omihpyNcrLEIKkyjv7UjfnFU1lQu2ku0Lwnog5C6yGrJ8PxUh77Ut/7s2ehlNNQD9cdYLW6LQVW5grzy9wnQVWXB7L3pL4+gdUnI6AyIkmJWvuTpGXuTJrp4Ez5pAgFSMr9T5F52HCwpjB0VUM5TVTw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=EiooqO9J; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="EiooqO9J" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1772058188; bh=9/gcaGlkQe1QrJ688U2wizDo4yOGGD0A8dLBqBOpGfc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EiooqO9Jvpj1eu3B3WnqpUrpbKM8bJaNoPXUGxgdBeGqPC1r5wFyRIsTBJ3vr3z/q FhAklYJzPJ3c/SE4o695qzin+1muwM3frUJuQM4aBD7qvvgcZvNTITW5TerFhQhVv4 r0icdDYkfEZrd5bnHIsQcfFkFOG3A9rhI/KOzoVs= Date: Wed, 25 Feb 2026 23:23:07 +0100 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: david.laight.linux@gmail.com Cc: Willy Tarreau , linux-kernel@vger.kernel.org, Cheng Li Subject: Re: [PATCH v3 next 06/17] tools/nolibc/printf: Change variables 'c' to 'ch' and 'tmpbuf[]' to 'outbuf[]' Message-ID: <1179fdc8-3083-4445-896a-cf5749fa99d1@t-8ch.de> References: <20260223101735.2922-1-david.laight.linux@gmail.com> <20260223101735.2922-7-david.laight.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260223101735.2922-7-david.laight.linux@gmail.com> On 2026-02-23 10:17:24+0000, david.laight.linux@gmail.com wrote: > From: David Laight > > Changing 'c' makes the code slightly easier to read because the variable > stands out from the single character literals (especially 'c'). > > Change tmpbuf[] to outbuf[] because 'out' points into it. > > The following patches pretty much rewrite the function so the > churn is limited. > > Acked-by: Willy Tarreau > Acked-by: "Thomas Weißschuh" > Signed-off-by: David Laight Applied, thanks. I applied it out-of-order and fixed it up to get it out of the way. FYI I won't finish the whole review today and for the meaty new bits Willy will also want to take a look. (...)