From: Jonathan Cameron <jic23@kernel.org>
To: Scott Matheina <scott@matheina.com>, linux-kernel@vger.kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCHv4 6/8] Fixed code wrap alignment with preceding (.
Date: Fri, 30 Dec 2016 18:51:25 +0000 [thread overview]
Message-ID: <117e82cb-b621-c261-a1fe-6a8b1c662944@kernel.org> (raw)
In-Reply-To: <1482696216-8013-7-git-send-email-scott@matheina.com>
On 25/12/16 19:56, Scott Matheina wrote:
> The code wasn't aligned with preceding ( on following lines, fixes
> this coding style issue.
>
> Signed-off-by: Scott Matheina <scott@matheina.com>
This looks fine, but is invasive enough I suspect it won't apply without
some of the earlier patches. If you care to respin this, please give
it a title of the same form I suggested for the previous patch.
Jonathan
> ---
> drivers/staging/iio/addac/adt7316.c | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 4678a64..91ac222 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -317,8 +317,8 @@ static IIO_DEVICE_ATTR(select_ex_temp, S_IRUGO | S_IWUSR,
> 0);
>
> static ssize_t adt7316_show_mode(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> struct iio_dev *dev_info = dev_to_iio_dev(dev);
> struct adt7316_chip_info *chip = iio_priv(dev_info);
> @@ -358,8 +358,8 @@ static IIO_DEVICE_ATTR(mode, S_IRUGO | S_IWUSR,
> 0);
>
> static ssize_t adt7316_show_all_modes(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> return sprintf(buf, "single_channel\nround_robin\n");
> }
> @@ -367,8 +367,8 @@ static ssize_t adt7316_show_all_modes(struct device *dev,
> static IIO_DEVICE_ATTR(all_modes, S_IRUGO, adt7316_show_all_modes, NULL, 0);
>
> static ssize_t adt7316_show_ad_channel(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> struct iio_dev *dev_info = dev_to_iio_dev(dev);
> struct adt7316_chip_info *chip = iio_priv(dev_info);
> @@ -383,7 +383,7 @@ static ssize_t adt7316_show_ad_channel(struct device *dev,
> return sprintf(buf, "1 - Internal Temperature\n");
> case ADT7316_AD_SINGLE_CH_EX:
> if (((chip->id & ID_FAMILY_MASK) == ID_ADT75XX) &&
> - (chip->config1 & ADT7516_SEL_AIN1_2_EX_TEMP_MASK) == 0)
> + (chip->config1 & ADT7516_SEL_AIN1_2_EX_TEMP_MASK) == 0)
> return sprintf(buf, "2 - AIN1\n");
>
> return sprintf(buf, "2 - External Temperature\n");
> @@ -451,8 +451,8 @@ static IIO_DEVICE_ATTR(ad_channel, S_IRUGO | S_IWUSR,
> 0);
>
> static ssize_t adt7316_show_all_ad_channels(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> struct iio_dev *dev_info = dev_to_iio_dev(dev);
> struct adt7316_chip_info *chip = iio_priv(dev_info);
> @@ -472,8 +472,8 @@ static IIO_DEVICE_ATTR(all_ad_channels, S_IRUGO,
> adt7316_show_all_ad_channels, NULL, 0);
>
> static ssize_t adt7316_show_disable_averaging(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> struct iio_dev *dev_info = dev_to_iio_dev(dev);
> struct adt7316_chip_info *chip = iio_priv(dev_info);
> @@ -511,8 +511,8 @@ static IIO_DEVICE_ATTR(disable_averaging, S_IRUGO | S_IWUSR,
> 0);
>
> static ssize_t adt7316_show_enable_smbus_timeout(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> struct iio_dev *dev_info = dev_to_iio_dev(dev);
> struct adt7316_chip_info *chip = iio_priv(dev_info);
> @@ -550,8 +550,8 @@ static IIO_DEVICE_ATTR(enable_smbus_timeout, S_IRUGO | S_IWUSR,
> 0);
>
> static ssize_t adt7316_show_powerdown(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> struct iio_dev *dev_info = dev_to_iio_dev(dev);
> struct adt7316_chip_info *chip = iio_priv(dev_info);
> @@ -588,8 +588,8 @@ static IIO_DEVICE_ATTR(powerdown, S_IRUGO | S_IWUSR,
> 0);
>
> static ssize_t adt7316_show_fast_ad_clock(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> struct iio_dev *dev_info = dev_to_iio_dev(dev);
> struct adt7316_chip_info *chip = iio_priv(dev_info);
>
next prev parent reply other threads:[~2016-12-30 18:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-25 19:56 [PATCHv4 0/8] Checkpatch fixes to driver/staging/iio/addac Scott Matheina
2016-12-25 19:56 ` [PATCHv4 1/8] fixed long description text exceeding 80 characters Scott Matheina
2016-12-30 18:40 ` Jonathan Cameron
2016-12-25 19:56 ` [PATCHv4 2/8] Fixed variables not being consistently lower case Scott Matheina
2016-12-25 20:31 ` kbuild test robot
2016-12-25 19:56 ` [PATCHv4 3/8] Fix camel case issues Scott Matheina
2016-12-25 20:54 ` kbuild test robot
2016-12-30 18:45 ` Jonathan Cameron
2016-12-25 19:56 ` [PATCHv4 4/8] Fix braces not present on all arms of if else statement Scott Matheina
2016-12-30 18:46 ` Jonathan Cameron
2016-12-30 18:48 ` Jonathan Cameron
2016-12-25 19:56 ` [PATCHv4 5/8] Remove line after closing braces Scott Matheina
2016-12-25 19:56 ` [PATCHv4 6/8] Fixed code wrap alignment with preceding ( Scott Matheina
2016-12-30 18:51 ` Jonathan Cameron [this message]
2016-12-25 19:56 ` [PATCHv4 7/8] Changed code to align with coding style of using octat Scott Matheina
2016-12-25 20:41 ` kbuild test robot
2016-12-30 18:53 ` Jonathan Cameron
2016-12-25 19:56 ` [PATCHv4 8/8] Fixes style issues due to mis-aligned carry over lines Scott Matheina
2016-12-25 21:18 ` kbuild test robot
2016-12-30 18:56 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=117e82cb-b621-c261-a1fe-6a8b1c662944@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=scott@matheina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®