From: Joe Perches <joe@perches.com>
To: "Petr Sedlák" <hugosedlak@gmail.com>,
"Forest Bond" <forest@alittletooquiet.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: vt6655: Fix camel case of variable
Date: Sat, 29 Dec 2018 15:58:47 -0800 [thread overview]
Message-ID: <117f5de40dabc48457f8725ece6c5b659caff043.camel@perches.com> (raw)
In-Reply-To: <20181229225952.GA8447@PhilosophyOfMe>
On Sat, 2018-12-29 at 23:59 +0100, Petr Sedlák wrote:
> Replace variable uDelayUnit with u_delay_unit. Issue found by
> checkpatch.
probably better as a static inline too.
> diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h
[]
> @@ -42,15 +42,15 @@
> #define VNSvOutPortD(dwIOAddress, dwData) \
> iowrite32((u32)(dwData), dwIOAddress)
>
> -#define PCAvDelayByIO(uDelayUnit) \
> +#define PCAvDelayByIO(u_delay_unit) \
> do { \
> unsigned char byData; \
> unsigned long ii; \
> \
> - if (uDelayUnit <= 50) { \
> - udelay(uDelayUnit); \
> + if (u_delay_unit <= 50) { \
> + udelay(u_delay_unit); \
> } else { \
> - for (ii = 0; ii < (uDelayUnit); ii++) \
> + for (ii = 0; ii < (u_delay_unit); ii++) \
> byData = inb(0x61); \
> } \
> } while (0)
And as the thing is used only once with a #define
with a value less than 50, maybe just
udelay(CB_DELAY_LOOP_WAIT);
in that one place.
next prev parent reply other threads:[~2018-12-30 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 22:59 Petr Sedlák
2018-12-29 23:58 ` Joe Perches [this message]
2019-01-02 11:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=117f5de40dabc48457f8725ece6c5b659caff043.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=hugosedlak@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®