mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: kvm-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, shaohua.li@intel.com,
	lhcs-devel@lists.sourceforge.net, Avi Kivity <avi@qumranet.com>
Subject: [PATCH 6/7] KVM: Tune hotplug/suspend IPIs
Date: Thu, 24 May 2007 15:10:14 +0300	[thread overview]
Message-ID: <11800086151115-git-send-email-avi@qumranet.com> (raw)
In-Reply-To: <1180008615579-git-send-email-avi@qumranet.com>

The hotplug IPIs can be called from the cpu on which we are currently
running on, so use on_one_cpu().  Similarly, drop on_each_cpu() for the
suspend/resume callbacks, as we're in atomic context here and only one
cpu is up anyway.

Signed-off-by: Avi Kivity <avi@qumranet.com>
---
 drivers/kvm/kvm_main.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
index 9738d51..a632c8d 100644
--- a/drivers/kvm/kvm_main.c
+++ b/drivers/kvm/kvm_main.c
@@ -2921,13 +2921,13 @@ static int kvm_cpu_hotplug(struct notifier_block *notifier, unsigned long val,
 	case CPU_UP_CANCELED_FROZEN:
 		printk(KERN_INFO "kvm: disabling virtualization on CPU%d\n",
 		       cpu);
-		smp_call_function_single(cpu, hardware_disable, NULL, 0, 1);
+		on_one_cpu(cpu, hardware_disable, NULL, 0, 1);
 		break;
 	case CPU_ONLINE:
 	case CPU_ONLINE_FROZEN:
 		printk(KERN_INFO "kvm: enabling virtualization on CPU%d\n",
 		       cpu);
-		smp_call_function_single(cpu, hardware_enable, NULL, 0, 1);
+		on_one_cpu(cpu, hardware_enable, NULL, 0, 1);
 		break;
 	}
 	return NOTIFY_OK;
@@ -2984,13 +2984,13 @@ static void kvm_exit_debug(void)
 
 static int kvm_suspend(struct sys_device *dev, pm_message_t state)
 {
-	on_each_cpu(hardware_disable, NULL, 0, 0);
+	hardware_disable(NULL);
 	return 0;
 }
 
 static int kvm_resume(struct sys_device *dev)
 {
-	on_each_cpu(hardware_disable, NULL, 0, 0);
+	hardware_enable(NULL);
 	return 0;
 }
 
-- 
1.5.0.6


  parent reply	other threads:[~2007-05-24 12:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-24 12:10 [PATCH 0/7] KVM: Suspend and cpu hotplug fixes Avi Kivity
2007-05-24 12:10 ` [PATCH 1/7] HOTPLUG: Add CPU_DYING notifier Avi Kivity
2007-05-24 12:10 ` [PATCH 2/7] HOTPLUG: Adapt cpuset hotplug callback to CPU_DYING Avi Kivity
2007-05-24 12:10 ` [PATCH 3/7] HOTPLUG: Adapt thermal throttle " Avi Kivity
2007-05-24 12:10 ` [PATCH 4/7] SMP: Implement on_one_cpu() Avi Kivity
2007-05-24 13:36   ` [kvm-devel] " Heiko Carstens
2007-05-24 13:42     ` Avi Kivity
2007-05-24 13:43   ` Roland Dreier
2007-05-24 13:48     ` Avi Kivity
2007-05-24 12:10 ` [PATCH 5/7] KVM: Keep track of which cpus have virtualization enabled Avi Kivity
2007-05-24 12:10 ` Avi Kivity [this message]
2007-05-24 12:10 ` [PATCH 7/7] KVM: Use CPU_DYING for disabling virtualization Avi Kivity
2007-05-24 12:53 ` [kvm-devel] [PATCH 0/7] KVM: Suspend and cpu hotplug fixes Avi Kivity
2007-05-25  1:10 ` Shaohua Li
2007-05-25  8:28   ` Avi Kivity
2007-05-27 10:20     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11800086151115-git-send-email-avi@qumranet.com \
    --to=avi@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=lhcs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome