From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
dedekind@infradead.org, linux-mtd@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd/ubi: silence gcc warning
Date: Sun, 27 May 2007 07:48:03 -0500 [thread overview]
Message-ID: <1180270083.3360.45.camel@zod.rchland.ibm.com> (raw)
In-Reply-To: <20070527113254.GA11940@havoc.gtf.org>
On Sun, 2007-05-27 at 07:32 -0400, Jeff Garzik wrote:
> Silence the gcc warning
>
> drivers/mtd/ubi/eba.c: In function ‘ubi_eba_read_leb’:
> drivers/mtd/ubi/eba.c:371: warning: ‘crc’ may be used uninitialized in this function
>
> This is an example of the uninit'd-var warnings emitted by gcc that
> can be proven to be bogus.
>
> Normally I would commit this to my git repository containing
> such verified cases, but with all the goto-driven control flow in
> ubi_eba_read_leb(), I feel that initializing the 'crc' variable is
> an easy way to both shut up gcc, and also make the code less fragile
> for the long term.
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
next prev parent reply other threads:[~2007-05-27 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 11:32 Jeff Garzik
2007-05-27 12:48 ` Josh Boyer [this message]
2007-05-27 12:54 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180270083.3360.45.camel@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dedekind@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®