From: Richard Purdie <rpurdie@rpsys.net>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: David Brownell <david-b@pacbell.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Samsung LTV350QV LCD driver
Date: Tue, 29 May 2007 22:01:17 +0100 [thread overview]
Message-ID: <1180472477.5822.87.camel@localhost.localdomain> (raw)
In-Reply-To: <11804683571524-git-send-email-hskinnemoen@atmel.com>
On Tue, 2007-05-29 at 21:52 +0200, Haavard Skinnemoen wrote:
> This patch adds support for powering on and off the Samsung LTV350QV
> LCD panel via SPI. The driver responds to framebuffer power
> management, it powers off the panel on reboot/halt/poweroff, and it
> can also be controlled through sysfs. The panel is powered up when the
> module is loaded and off when the module is unloaded.
>
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
The LCD class device bits look fine to me. The only change I'd request
is not to change the order of things in drivers/video/backlight/Kconfig.
If you do want to reword one of those entries (which is what I think you
wanted to do), send it as a separate patch please.
David, any objections to the SPI bits?
Richard
next prev parent reply other threads:[~2007-05-29 21:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 19:52 Haavard Skinnemoen
2007-05-29 21:01 ` Richard Purdie [this message]
2007-05-29 21:38 ` David Brownell
2007-05-29 22:19 ` Richard Purdie
2007-05-30 10:46 ` [PATCH v2] " Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180472477.5822.87.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=david-b@pacbell.net \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome