From: Bryan Wu <bryan.wu@analog.com>
To: bryan.wu@analog.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
akpm@linux-foundation.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] [RAMFS NOMMU]: a bug in ramfs_nommu_resize function, passing old size to vmtruncate
Date: Thu, 31 May 2007 11:35:28 +0800 [thread overview]
Message-ID: <1180582528.10836.6.camel@roc-laptop> (raw)
In-Reply-To: <1180582315.10836.2.camel@roc-laptop>
On Thu, 2007-05-31 at 11:31 +0800, Bryan Wu wrote:
> It should be pass "newsize" to vmtruncate function to modify the
> inode->i_size,
> while the old size is passed to vmtruncate.
>
> This bug was catched by LTP truncate test case on Blackfin platform.
> After it was fixed, the LTP truncate test case passed.
>
> Signed-off-by: Bryan Wu <bryan.wu@analog.com>
> Cc: David Howells <dhowells@redhat.com>
> ---
> fs/ramfs/file-nommu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ramfs/file-nommu.c b/fs/ramfs/file-nommu.c
> index 3b481d5..9345a46 100644
> --- a/fs/ramfs/file-nommu.c
> +++ b/fs/ramfs/file-nommu.c
> @@ -179,7 +179,7 @@ static int ramfs_nommu_resize(struct inode *inode, loff_t newsize, loff_t size)
> return ret;
> }
>
> - ret = vmtruncate(inode, size);
> + ret = vmtruncate(inode, newsize);
>
> return ret;
> }
David:
Sorry for sending this email several times , my git-send-email got some
problem.
Thanks
-Bryan Wu
next prev parent reply other threads:[~2007-05-31 3:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 3:31 Bryan Wu
2007-05-31 3:35 ` Bryan Wu [this message]
2007-05-31 3:55 ` Linus Torvalds
2007-05-31 4:03 ` Bryan Wu
2007-05-31 4:18 ` Andrew Morton
2007-05-31 4:27 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180582528.10836.6.camel@roc-laptop \
--to=bryan.wu@analog.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®