From: Hans-Christian Egtvedt <hcegtvedt@atmel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Haavard Skinnemoen <hskinnemoen@atmel.com>,
Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH 1/1] Watchdog driver for AT32AP700X devices
Date: Fri, 08 Jun 2007 09:23:27 +0200 [thread overview]
Message-ID: <1181287407.28296.17.camel@localhost.localdomain> (raw)
In-Reply-To: <20070607160910.34d64842.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Thu, 2007-06-07 at 16:09 -0700, Andrew Morton wrote:
> On Wed, 6 Jun 2007 16:04:07 +0200
> Hans-Christian Egtvedt <hcegtvedt@atmel.com> wrote:
>
> > This patch adds support for the built in watchdog in AT32AP700X devices.
> >
> > Tested on AT32AP7000 and ATSTK1000.
> >
> > Hardware documentation can be found in the AT32AP7000 datasheet.
> >
> > ...
> >
> > +static int __init at32_wdt_probe(struct platform_device *pdev)
> > +{
<cut start of _probe>
> > + wdt->regs = ioremap(regs->start, regs->end - regs->start + 1);
>
> I see an ioremap(), but there are no iounmap()s anywhere.
Hmm, that would be my fault, please see the attach patch, it should
apply clean to -mm after your two -fix{1,2} patches.
--
With kind regards,
Hans-Christian Egtvedt, siv.ing. (M.Sc.)
Applications Engineer - AVR32 System Solutions - Atmel Norway
[-- Attachment #2: 0001-at32ap700x-wdt-add-missing-iounmap-in-_remove.txt --]
[-- Type: application/mbox, Size: 881 bytes --]
next prev parent reply other threads:[~2007-06-08 7:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 14:04 Hans-Christian Egtvedt
2007-06-07 23:09 ` Andrew Morton
2007-06-08 7:23 ` Hans-Christian Egtvedt [this message]
2007-06-08 11:20 ` Hans-Christian Egtvedt
2007-06-10 20:31 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181287407.28296.17.camel@localhost.localdomain \
--to=hcegtvedt@atmel.com \
--cc=akpm@linux-foundation.org \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®