From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759384AbXFMRBh (ORCPT ); Wed, 13 Jun 2007 13:01:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758429AbXFMRB1 (ORCPT ); Wed, 13 Jun 2007 13:01:27 -0400 Received: from mqa44.m2.home.ne.jp ([220.152.32.185]:61698 "EHLO mqa44.m2.home.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758156AbXFMRB0 (ORCPT ); Wed, 13 Jun 2007 13:01:26 -0400 X-Greylist: delayed 14907 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 Jun 2007 13:01:25 EDT Subject: Re: [patch 1/6] 8139too: force media setting cleanup From: Kyuma Ohta To: Jeff Garzik , Linux Kernel Mailing List Cc: akpm@linux-foundation.org, leewkb@yahoo.com, netdev In-Reply-To: <46560567.5060708@garzik.org> References: <200705232134.l4NLYcm2000578@shell0.pdx.osdl.net> <46560567.5060708@garzik.org> Content-Type: text/plain Date: Wed, 13 Jun 2007 21:52:56 +0900 Message-Id: <1181739176.23954.23.camel@melchior> Mime-Version: 1.0 X-Mailer: Evolution 2.10.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi, I was testing 2.6.22-rc4 from yesterday, but communication speed of 8139 side is very slower than 2.6.21.* (less than 10kbytes/sec at 100MBPS,FULL-DUPLEX). I was not test from 2.6.22-rc ,yesterday I started to test 2.6.22-rc. So, I *must* set HALF-DUPLEX to 8139 side below: ethtool -s ethx speed 100 duplex half autoneg on *x is number of 8139 assigned from udev. So,Pls.apply this patch to upstream,and I test this too. Best Regards, Ohta. Appendix information: archtecture: x86_64 Main Board : Gigabyte GA-M69P-M3 (rev.1.0?) MPU: Athlon 64x2 4600+ (Not overclocked) Chipset : nVidia nForce430+GForce 6150 Complex chip Memory : PC-5300 2GB (w/shared graphix memory) Ether: nForce430 (within complex chip,using forcedeth) Realtec 8139C (+?) (on PCI Slot,using 8139too) OS: Debian GNU/Linux "sid" (after "etch",using glibc2.5). On 2007-05-24 (Thu) 17:36 -0400 , Jeff Garzik Wrote: > akpm@linux-foundation.org wrote: > > From: Bernard Lee > > > > Setting bit 4 & 5 alone in 8139too module media option does not really > > force 100Mbps full-duplex mode. When media option bit 0-3 is cleared, > > 8139too module does not force media setting. Therefore, bit 0-3 requires > > to be set for bit 4 & 5 to take effect. The hidden bit 0-3 setting is not > > stated in module description. > > > > It can be fixed by changing rtl8139_private structure default_port bitfield > > from 4-bit to 6-bit. > > > > Besides, module media bit 9 is a duplicate of bit 4 (full-duplex). It is > > suggested that bit 9 is freed. A remark is added to module description > > that bit 0 can be used to force setting. It helps to clarify 10Mbps > > half-duplex mode. > > > > Signed-off-by: Bernard Lee > > Cc: Jeff Garzik > > Signed-off-by: Andrew Morton > > --- > > > > drivers/net/8139too.c | 8 ++++---- > > 1 files changed, 4 insertions(+), 4 deletions(-) > > (re-replying, just to refresh everybody on the status) > > The status of this patch is HOLD, and has been for months. > > AFAICS this is a behavior change that differs from other Becker-derived > drivers. I would suggest looking at other drivers. > > Furthermore, people should be using ethtool to set media. Rather than > changing the behavior of this module parameter to be non-standard, I > feel it is better to (a) leave it as is or (b) remove it completely. > > Jeff