mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	"Linux and Kernel Video" <video4linux-list@redhat.com>,
	"Toralf Förster" <toralf.foerster@gmx.de>,
	"Luca Risolia" <luca.risolia@studio.unibo.it>,
	LKML <linux-kernel@vger.kernel.org>,
	"Roman Zippel" <zippel@linux-m68k.org>,
	"Satyam Sharma" <satyam.sharma@gmail.com>,
	"Andreas Herrmann" <andreas.herrmann3@amd.com>,
	"Oliver Neukum" <oneukum@suse.de>,
	"Trent Piepho" <xyzzy@speakeasy.org>
Subject: Re: [patch] 2.6.22-rc Kconfig troubles when using menuconfig
Date: Sat, 23 Jun 2007 19:26:26 -0300	[thread overview]
Message-ID: <1182637586.10174.36.camel@gaivota> (raw)
In-Reply-To: <Pine.LNX.4.64.0706230915540.26568@fbirervta.pbzchgretzou.qr>

Hi Jan,



Your patch seems OK to me, providing that we also add the Andreas patch:

---

Correct Kconfig to avoid compile errors like
    
 drivers/built-in.o: In function `sn9c102_usb_disconnect':
 sn9c102_core.c:(.text+0x8d840): undefined reference to `usb_get_dev'
    
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>

diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index 4cca551..4754d98 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -687,7 +687,7 @@ config VIDEO_CAFE_CCIC
 #
 
 menuconfig V4L_USB_DRIVERS
-	bool "V4L USB devices"
+	tristate "V4L USB devices"
 	depends on USB
 	default y
 

Em Sáb, 2007-06-23 às 09:20 +0200, Jan Engelhardt escreveu:
> Anyone with strong objections to this patch? (Hopefully) fixes the 
> kconfig issue for now.
> 
> 
> Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
	(for both Andreas and your patch)

-- 
Cheers,
Mauro


  reply	other threads:[~2007-06-23 22:27 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200706211117.55908.toralf.foerster@gmx.de>
     [not found] ` <200706211231.53898.luca.risolia@studio.unibo.it>
     [not found]   ` <200706211326.45031.toralf.foerster@gmx.de>
     [not found]     ` <200706211350.14526.oneukum@suse.de>
2007-06-22 13:22       ` Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c Mauro Carvalho Chehab
2007-06-22 13:46         ` Andreas Herrmann
2007-06-22 13:51           ` Jan Engelhardt
2007-06-22 14:23             ` Andreas Herrmann
2007-06-22 15:03             ` Mauro Carvalho Chehab
2007-06-22 15:32               ` Andreas Herrmann
2007-06-22 15:45               ` Oliver Neukum
2007-06-22 14:27         ` Roman Zippel
2007-06-22 15:18           ` Jan Engelhardt
2007-06-22 16:24             ` Roman Zippel
2007-06-22 16:42               ` Jan Engelhardt
2007-06-22 20:17                 ` Satyam Sharma
2007-06-22 21:00                   ` Satyam Sharma
2007-06-22 15:21           ` Mauro Carvalho Chehab
2007-06-22 16:31             ` Roman Zippel
2007-06-22 20:20         ` Trent Piepho
2007-06-22 21:20           ` Satyam Sharma
2007-06-22 21:45             ` Roman Zippel
2007-06-22 22:01               ` Satyam Sharma
2007-06-22 22:21                 ` Roman Zippel
2007-06-22 22:33                   ` Satyam Sharma
2007-06-22 23:12                     ` Roman Zippel
2007-06-22 23:26                       ` Satyam Sharma
2007-06-22 23:39                         ` Roman Zippel
2007-06-22 23:49                           ` Satyam Sharma
2007-06-23  0:26                             ` Roman Zippel
2007-06-23  6:57                               ` Jan Engelhardt
2007-06-25  0:11                                 ` Roman Zippel
2007-06-22 22:11             ` Jan Engelhardt
2007-06-23 12:28               ` Kconfig troubles when using menuconfig - Was: [patch]Re: " Oleg Verych
2007-06-23 22:33             ` Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] " Trent Piepho
2007-06-24  3:28               ` Satyam Sharma
2007-06-23  7:20           ` [patch] 2.6.22-rc Kconfig troubles when using menuconfig Jan Engelhardt
2007-06-23 22:26             ` Mauro Carvalho Chehab [this message]
2007-06-24  0:14               ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1182637586.10174.36.camel@gaivota \
    --to=mchehab@infradead.org \
    --cc=andreas.herrmann3@amd.com \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.risolia@studio.unibo.it \
    --cc=oneukum@suse.de \
    --cc=satyam.sharma@gmail.com \
    --cc=toralf.foerster@gmx.de \
    --cc=torvalds@linux-foundation.org \
    --cc=video4linux-list@redhat.com \
    --cc=xyzzy@speakeasy.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®