mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Rob Landley <rob@landley.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix headers_install for x86-64 (now with less whitespace damage!)
Date: Tue, 26 Jun 2007 15:03:49 +0100	[thread overview]
Message-ID: <1182866629.8896.37.camel@pmac.infradead.org> (raw)
In-Reply-To: <200706260912.37441.rob@landley.net>

On Tue, 2007-06-26 at 09:12 -0400, Rob Landley wrote:
> Signed-off-by: Rob Landley <rob@landley.net>
>  
>  A bug in headers_install for ARCH=x86_64 yields an asm/ directory full of
>  files all of which are using the same #ifdef guard, "__ASM_STUB_" with no
>  postfix. So the second and later asm files #included in the same C file
>  (often through standard headers like ioctl.h) yields no symbols.

Interesting. It works here with bash 3.2 -- I thought it was the _first_
shell which expanded $FNAME and $STUBDEF inside the parentheses. Which
shell are you using?

Is it sufficient just to add the missing semicolon after FNAME=...?

-- 
dwmw2


  reply	other threads:[~2007-06-26 14:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-26 13:12 Rob Landley
2007-06-26 14:03 ` David Woodhouse [this message]
2007-06-26 14:48   ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1182866629.8896.37.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®