From: David Woodhouse <dwmw2@infradead.org>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] LinuxPPS (with new syscalls API)
Date: Thu, 28 Jun 2007 12:44:20 +0100 [thread overview]
Message-ID: <1183031060.1170.145.camel@pmac.infradead.org> (raw)
In-Reply-To: <20070628084003.GQ13886@enneenne.com>
On Thu, 2007-06-28 at 10:40 +0200, Rodolfo Giometti wrote:
> On Thu, Jun 28, 2007 at 09:31:14AM +0100, David Woodhouse wrote:
> > On Thu, 2007-06-28 at 10:15 +0200, Rodolfo Giometti wrote:
> > > Do you think I should add these functions into my patch, even if I
> > > cannot test it, or it's enought providing just the
> > > compat_sys_time_pps_fetch() function?
> >
> > Probably best to put them in. That way, you make it easier for people to
>
> Mmm... so I should provide new syscalls for _all_
> architectures... gulp! :)
It's nice if you can do so, but I wouldn't suggest that you _have_ to.
I have to admit that I rarely bother actually wiring new system calls up
on anything but PowerPC to start with.
The important thing is that you've _considered_ the other architectures,
and the 32/64 compatibility implications. As long as the API of your new
system call is sensible and takes that kind of thing into account, it
should be fine.
Had you considered changing the API so that you don't need the
compatibility wrapper at all? Could you take an integer number of µS or
ms instead of a struct timespec?
--
dwmw2
next prev parent reply other threads:[~2007-06-28 11:44 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 10:06 Rodolfo Giometti
2007-06-26 10:57 ` David Woodhouse
2007-06-26 17:06 ` Rodolfo Giometti
2007-06-26 17:38 ` David Woodhouse
2007-06-26 18:13 ` Rodolfo Giometti
2007-06-26 18:20 ` David Woodhouse
2007-06-27 10:14 ` Rodolfo Giometti
2007-06-27 10:18 ` David Woodhouse
2007-06-27 12:58 ` Rodolfo Giometti
2007-06-27 16:11 ` David Woodhouse
2007-06-27 17:45 ` Rodolfo Giometti
2007-06-27 17:49 ` David Woodhouse
2007-06-27 22:46 ` Rodolfo Giometti
2007-06-28 8:08 ` David Woodhouse
2007-06-28 8:15 ` Rodolfo Giometti
2007-06-28 8:31 ` David Woodhouse
2007-06-28 8:40 ` Rodolfo Giometti
2007-06-28 11:44 ` David Woodhouse [this message]
2007-06-28 14:15 ` Rodolfo Giometti
2007-06-28 16:14 ` [PATCH] LinuxPPS (with new syscalls API) - new version Rodolfo Giometti
2007-06-29 11:38 ` David Woodhouse
2007-06-29 15:08 ` Rodolfo Giometti
2007-06-29 15:25 ` David Woodhouse
2007-06-29 15:38 ` Rodolfo Giometti
2007-06-29 15:41 ` David Woodhouse
2007-06-29 16:23 ` Rodolfo Giometti
2007-06-29 16:23 ` David Woodhouse
2007-06-29 16:36 ` Rodolfo Giometti
2007-06-29 16:38 ` David Woodhouse
2007-06-29 15:55 ` David Woodhouse
2007-06-29 16:34 ` Rodolfo Giometti
2007-06-29 16:40 ` David Woodhouse
2007-06-30 17:13 ` Rodolfo Giometti
2007-07-01 7:13 ` Stephen Rothwell
2007-07-01 19:24 ` Rodolfo Giometti
2007-07-10 16:01 ` Lennart Sorensen
2007-07-10 16:36 ` Rodolfo Giometti
2007-07-10 16:36 ` David Woodhouse
2007-07-10 16:44 ` Rodolfo Giometti
2007-07-10 22:03 ` Lennart Sorensen
2007-07-11 8:06 ` Rodolfo Giometti
2007-07-11 15:22 ` Lennart Sorensen
2007-07-11 16:32 ` Rodolfo Giometti
2007-07-11 1:18 ` Roman Zippel
2007-07-11 15:24 ` Lennart Sorensen
2007-07-11 16:35 ` Rodolfo Giometti
2007-07-11 17:34 ` Roman Zippel
2007-07-01 12:03 ` David Woodhouse
2007-07-01 19:27 ` Rodolfo Giometti
2007-07-03 9:48 ` Rodolfo Giometti
2007-07-03 13:09 ` David Woodhouse
2007-07-03 13:21 ` Rodolfo Giometti
2007-07-09 13:19 ` Rodolfo Giometti
2007-07-10 16:05 ` David Woodhouse
2007-07-10 16:38 ` Rodolfo Giometti
2007-07-11 9:17 ` David Woodhouse
2007-07-11 10:46 ` Rodolfo Giometti
2007-06-30 8:38 ` Christoph Hellwig
2007-06-30 17:06 ` Rodolfo Giometti
2007-07-08 9:05 ` Oleg Verych
2007-07-09 9:16 ` Rodolfo Giometti
2007-07-09 10:56 ` Makefiles for GNU make (Re: [PATCH] LinuxPPS (with new syscalls API) - new version) Oleg Verych
2007-07-09 10:57 ` Rodolfo Giometti
[not found] <fa.KzVWiacZsGdGiMxLldFOOPOdIEw@ifi.uio.no>
[not found] ` <fa.TdDfr0FpGG8OjqtqWj6RNRusuU0@ifi.uio.no>
[not found] ` <fa.qT2j8q7/hQ2xVpeJCg7VGv+FvpI@ifi.uio.no>
[not found] ` <fa.RLNIoDXtVxFnlYMPJh2Q2+yDDOk@ifi.uio.no>
2007-06-26 23:33 ` [PATCH] LinuxPPS (with new syscalls API) Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183031060.1170.145.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=giometti@enneenne.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®