From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755552AbXGHEkh (ORCPT ); Sun, 8 Jul 2007 00:40:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750888AbXGHEkb (ORCPT ); Sun, 8 Jul 2007 00:40:31 -0400 Received: from gate.crashing.org ([63.228.1.57]:41377 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750814AbXGHEka (ORCPT ); Sun, 8 Jul 2007 00:40:30 -0400 Subject: Re: [PATCH] Remove process freezer from suspend to RAM pathway From: Benjamin Herrenschmidt To: Alan Stern Cc: Kyle Moffett , Nigel Cunningham , Pavel Machek , "Rafael J. Wysocki" , Matthew Garrett , linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org In-Reply-To: References: Content-Type: text/plain Date: Sun, 08 Jul 2007 14:39:36 +1000 Message-Id: <1183869576.3388.250.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > In my defense, you should realize that until Rafael's notifier chain > was added (just a few weeks ago, still not in mainline I believe) there > was no other way to do it. Plug activity needs to be stopped before > the child devices are suspended, and the PM core does not send any > notification to drivers at that time. All it does is activate the > freezer. That's true. That was one of the reason I've always wanted the pre-suspend and post-resume hooks. (I prefer keeping the ordering there too, rather than a notifier, but a notifier is fine I suppose). Among the clients we want here the firmware stuff, the allocators, etc... to get themselves in conditions that won't deadlock during suspend cycle. I think that's a much bigger issue overall than freezer vs. no freezer :-) Ben.