From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761846AbXGJCHA (ORCPT ); Mon, 9 Jul 2007 22:07:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755496AbXGJCGx (ORCPT ); Mon, 9 Jul 2007 22:06:53 -0400 Received: from ozlabs.org ([203.10.76.45]:53850 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755061AbXGJCGw (ORCPT ); Mon, 9 Jul 2007 22:06:52 -0400 Subject: Re: maps2-move-the-page-walker-code-to-lib.patch From: Rusty Russell To: Matt Mackall Cc: Jeremy Fitzhardinge , David Rientjes , Andrew Morton , lkml - Kernel Mailing List , Sam Ravnborg In-Reply-To: <20070709202217.GS11115@waste.org> References: <1183873796.6005.269.camel@localhost.localdomain> <20070709202217.GS11115@waste.org> Content-Type: text/plain Date: Tue, 10 Jul 2007 12:06:35 +1000 Message-Id: <1184033195.6005.439.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2007-07-09 at 15:22 -0500, Matt Mackall wrote: > On Sun, Jul 08, 2007 at 03:49:56PM +1000, Rusty Russell wrote: > > Matt wrote: > > > This lets it get shared outside of proc/ and linked in only when needed. > > > > Erk, this really belongs in the mm dir. You can use "lib-y += > > pagewalk.o" there, and it seems to work as well as doing it in lib. > > Are you sure? I tested that a few months ago and it didn't work for > me. I seem to recall it wanted a chunk of makefile surgery. Well, I tested here and it worked unless I screwed something (producing lib.a in mm/ and linking it in). And when I turned off all the CONFIG options which required it, the symbols disappeared from the vmlinux... Rusty.