mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: Jens Axboe <jens.axboe@oracle.com>
Subject: [PATCH 03/33] block: convert to using sg helpers
Date: Mon, 16 Jul 2007 11:47:17 +0200	[thread overview]
Message-ID: <11845792672399-git-send-email-jens.axboe@oracle.com> (raw)
In-Reply-To: <11845792671245-git-send-email-jens.axboe@oracle.com>

Convert the main rq mapper (blk_rq_map_sg()) to the sg helper setup.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
---
 block/ll_rw_blk.c |   19 ++++++++++++-------
 1 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c
index ef42bb2..ab71087 100644
--- a/block/ll_rw_blk.c
+++ b/block/ll_rw_blk.c
@@ -30,6 +30,7 @@
 #include <linux/cpu.h>
 #include <linux/blktrace_api.h>
 #include <linux/fault-inject.h>
+#include <linux/scatterlist.h>
 
 /*
  * for max sense size
@@ -1307,9 +1308,11 @@ static int blk_hw_contig_segment(request_queue_t *q, struct bio *bio,
  * map a request to scatterlist, return number of sg entries setup. Caller
  * must make sure sg can hold rq->nr_phys_segments entries
  */
-int blk_rq_map_sg(request_queue_t *q, struct request *rq, struct scatterlist *sg)
+int blk_rq_map_sg(request_queue_t *q, struct request *rq,
+		  struct scatterlist *sglist)
 {
 	struct bio_vec *bvec, *bvprv;
+	struct scatterlist *next_sg, *sg;
 	struct bio *bio;
 	int nsegs, i, cluster;
 
@@ -1320,6 +1323,7 @@ int blk_rq_map_sg(request_queue_t *q, struct request *rq, struct scatterlist *sg
 	 * for each bio in rq
 	 */
 	bvprv = NULL;
+	sg = next_sg = &sglist[0];
 	rq_for_each_bio(bio, rq) {
 		/*
 		 * for each segment in bio
@@ -1328,7 +1332,7 @@ int blk_rq_map_sg(request_queue_t *q, struct request *rq, struct scatterlist *sg
 			int nbytes = bvec->bv_len;
 
 			if (bvprv && cluster) {
-				if (sg[nsegs - 1].length + nbytes > q->max_segment_size)
+				if (sg->length + nbytes > q->max_segment_size)
 					goto new_segment;
 
 				if (!BIOVEC_PHYS_MERGEABLE(bvprv, bvec))
@@ -1336,14 +1340,15 @@ int blk_rq_map_sg(request_queue_t *q, struct request *rq, struct scatterlist *sg
 				if (!BIOVEC_SEG_BOUNDARY(q, bvprv, bvec))
 					goto new_segment;
 
-				sg[nsegs - 1].length += nbytes;
+				sg->length += nbytes;
 			} else {
 new_segment:
-				memset(&sg[nsegs],0,sizeof(struct scatterlist));
-				sg[nsegs].page = bvec->bv_page;
-				sg[nsegs].length = nbytes;
-				sg[nsegs].offset = bvec->bv_offset;
+				sg = next_sg;
+				next_sg = sg_next(sg);
 
+				sg->page = bvec->bv_page;
+				sg->length = nbytes;
+				sg->offset = bvec->bv_offset;
 				nsegs++;
 			}
 			bvprv = bvec;
-- 
1.5.3.rc0.90.gbaa79


  parent reply	other threads:[~2007-07-16  9:49 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-16  9:47 [PATCH 00/33] SG table chaining support Jens Axboe
2007-07-16  9:47 ` [PATCH 01/33] crypto: don't pollute the global namespace with sg_next() Jens Axboe
2007-07-16  9:47 ` [PATCH 02/33] Add sg helpers for iterating over a scatterlist table Jens Axboe
2007-07-16  9:47 ` Jens Axboe [this message]
2007-07-16 19:21   ` [PATCH 03/33] block: convert to using sg helpers Bartlomiej Zolnierkiewicz
2007-07-16 19:14     ` Jens Axboe
2007-07-16  9:47 ` [PATCH 04/33] scsi: " Jens Axboe
2007-07-16  9:47 ` [PATCH 05/33] Add chained sg support to linux/scatterlist.h Jens Axboe
2007-07-16 19:21   ` Bartlomiej Zolnierkiewicz
2007-07-16 19:15     ` Jens Axboe
2007-07-16  9:47 ` [PATCH 06/33] i386 dma_map_sg: convert to using sg helpers Jens Axboe
2007-07-16  9:47 ` [PATCH 07/33] i386: enable sg chaining Jens Axboe
2007-07-16  9:47 ` [PATCH 08/33] swiotlb: sg chaining support Jens Axboe
2007-07-16  9:47 ` [PATCH 09/33] x86-64: update iommu/dma mapping functions to sg helpers Jens Axboe
2007-07-16 20:06   ` Andrew Morton
2007-07-16 20:10     ` Jens Axboe
2007-07-16 20:34       ` Andrew Morton
2007-07-16 22:08         ` Muli Ben-Yehuda
2007-07-17  7:38           ` Jens Axboe
2007-07-17  8:49             ` Muli Ben-Yehuda
2007-07-17  8:51               ` Jens Axboe
2007-07-17  9:00                 ` Muli Ben-Yehuda
2007-07-17  7:02         ` Jens Axboe
2007-07-17  7:56           ` Jens Axboe
2007-07-17 11:03   ` Muli Ben-Yehuda
2007-07-17 11:05     ` Jens Axboe
2007-07-17 11:10       ` Muli Ben-Yehuda
2007-07-16  9:47 ` [PATCH 10/33] x86-64: enable sg chaining Jens Axboe
2007-07-16  9:47 ` [PATCH 11/33] IA64: sg chaining support Jens Axboe
2007-07-16  9:47 ` [PATCH 12/33] PPC: " Jens Axboe
2007-07-16  9:47 ` [PATCH 13/33] SPARC: " Jens Axboe
2007-07-16 11:29   ` David Miller
2007-07-16  9:47 ` [PATCH 14/33] SPARC64: " Jens Axboe
2007-07-16 11:29   ` David Miller
2007-07-16  9:47 ` [PATCH 15/33] scsi: simplify scsi_free_sgtable() Jens Axboe
2007-07-16  9:47 ` [PATCH 16/33] SCSI: support for allocating large scatterlists Jens Axboe
2007-07-16  9:47 ` [PATCH 17/33] ll_rw_blk: temporarily enable max_segments tweaking Jens Axboe
2007-07-16  9:47 ` [PATCH 18/33] libata: convert to using sg helpers Jens Axboe
2007-07-16  9:47 ` [PATCH 19/33] scsi_debug: support sg chaining Jens Axboe
2007-07-16  9:47 ` [PATCH 20/33] scsi generic: sg chaining support Jens Axboe
2007-07-16  9:47 ` [PATCH 21/33] qla1280: " Jens Axboe
2007-07-16  9:47 ` [PATCH 22/33] aic94xx: " Jens Axboe
2007-07-16  9:47 ` [PATCH 23/33] qlogicpti: " Jens Axboe
2007-07-16  9:47 ` [PATCH 24/33] ide-scsi: " Jens Axboe
2007-07-18 21:03   ` Bartlomiej Zolnierkiewicz
2007-07-16  9:47 ` [PATCH 25/33] gdth: " Jens Axboe
2007-07-16  9:47 ` [PATCH 26/33] aha1542: convert to use the data buffer accessors Jens Axboe
2007-07-16  9:47 ` [PATCH 27/33] advansys: " Jens Axboe
2007-07-16  9:47 ` [PATCH 28/33] ia64 simscsi: convert to use " Jens Axboe
2007-07-16  9:47 ` [PATCH 29/33] infiniband: sg chaining support Jens Axboe
2007-07-16 13:21   ` FUJITA Tomonori
2007-07-16 13:26     ` Jens Axboe
2007-07-16  9:47 ` [PATCH 30/33] USB storage: " Jens Axboe
2007-07-17  6:12   ` Greg KH
2007-07-17  7:01     ` Jens Axboe
2007-07-17  7:05       ` Greg KH
2007-07-17  7:07         ` Jens Axboe
2007-07-16  9:47 ` [PATCH 31/33] Fusion: " Jens Axboe
2007-07-16 13:20   ` FUJITA Tomonori
2007-07-16 13:25     ` Jens Axboe
2007-07-16  9:47 ` [PATCH 32/33] i2o: " Jens Axboe
2007-07-16  9:47 ` [PATCH 33/33] IDE: " Jens Axboe
2007-07-18 20:56   ` Bartlomiej Zolnierkiewicz
2007-07-19  6:19     ` Jens Axboe
2007-07-16 13:19 ` [PATCH 00/33] SG table " FUJITA Tomonori
2007-07-16 13:23   ` Jens Axboe
2007-07-16 13:19 ` FUJITA Tomonori
2007-07-16 13:24   ` Jens Axboe
2007-07-16 14:05 ` John Stoffel
2007-07-16 14:23   ` Martin K. Petersen
2007-07-16 14:43     ` Jens Axboe
2007-07-16 16:02     ` Kai Makisara
2007-07-16 16:43       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11845792672399-git-send-email-jens.axboe@oracle.com \
    --to=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®