From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1764013AbXGQNFa@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1764013AbXGQNFa (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Jul 2007 09:05:30 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751184AbXGQNFW
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 17 Jul 2007 09:05:22 -0400
Received: from crystal.sipsolutions.net ([195.210.38.204]:53834 "EHLO
	sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750767AbXGQNFV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Jul 2007 09:05:21 -0400
Subject: Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1
From: Johannes Berg <johannes@sipsolutions.net>
To: Soeren Sonnenburg <kernel@nn7.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
       linux-input@atrey.karlin.mff.cuni.cz,
       linux-usb-devel@lists.sourceforge.net,
       Matthew Garrett <mjg59@srcf.ucam.org>,
       Nicolas Boichat <nicolas@boichat.ch>,
       Michael Hanselmann <linux-kernel@hansmi.ch>,
       Peter Osterlund <petero2@telia.com>,
       Frank Arnold <frank@scirocco-5v-turbo.de>,
       Stelian Pop <stelian@popies.net>, Greg Kroah-Hartman <greg@kroah.com>
In-Reply-To: <1184656218.14051.43.camel@localhost>
References: <1184656218.14051.43.camel@localhost>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-ltW17/tmw41IOYBdWxxf"
Date: Tue, 17 Jul 2007 15:03:44 +0200
Message-Id: <1184677424.3773.87.camel@johannes.berg>
Mime-Version: 1.0
X-Mailer: Evolution 2.10.2 
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org


--=-ltW17/tmw41IOYBdWxxf
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

Good stuff :)

> +	int                     idlecount;      /* number of empty packets */

should probably use tabs here.

> +	size =3D usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> +			       ATP_GEYSER3_MODE_WRITE_REQUEST_ID,
> +			       USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE,
> +			       ATP_GEYSER3_MODE_REQUEST_VALUE,
> +			       ATP_GEYSER3_MODE_REQUEST_INDEX, &data, 8, 5000);
> +	<eol>

trailing whitespace.

=20
> +	input_report_key(dev->input, BTN_LEFT, dev->data[dev->datalen-1] & 1);
> +


> @@ -449,10 +511,19 @@ static void atp_complete(struct urb* urb)
> =20
>  		/* reset the accumulator on release */
>  		memset(dev->xy_acc, 0, sizeof(dev->xy_acc));
> -	}
> =20
> -	input_report_key(dev->input, BTN_LEFT,
> -			 !!dev->data[dev->datalen - 1]);

Any hint as to why you move this? The different test, yes, ok, you
explained that, but moving it?

johannes

--=-ltW17/tmw41IOYBdWxxf
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Comment: Johannes Berg (powerbook)

iD8DBQBGnL4w/ETPhpq3jKURAkBNAJ4piCS61A4pde11xfdb3/JOhxONFACgq0J2
/vet92dmqmBJAScDM999TQE=
=10ID
-----END PGP SIGNATURE-----

--=-ltW17/tmw41IOYBdWxxf--