mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Victor <andrew@sanpeople.com>
To: Hans-Christian Egtvedt <hcegtvedt@atmel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kernel-avr32 <kernel@avr32linux.org>,
	David Brownell <david-b@pacbell.net>,
	Patrice Vilchez <patrice.vilchez@rfo.atmel.com>,
	Nicolas Ferre <nicolas.ferre@rfo.atmel.com>,
	Hans-Christian Egtvedt <egtvedt@samfundet.no>
Subject: Re: [PATCH 1/1][RESEND] Driver for the Atmel on-chip SSC on AT32AP and AT91.
Date: 19 Jul 2007 10:29:19 +0200	[thread overview]
Message-ID: <1184833759.15007.33.camel@fuzzie.sanpeople.com> (raw)
In-Reply-To: <469E6C00.3060506@atmel.com>

hi Hans-Christian,

> This driver is used in the ALSA sound driver for the AT73C213 external DAC on
> the ATSTK1000 development board for AVR32. This sound driver will be submitted
> soon.

Seems to be more of an SCC unit allocation library, but OK.

I've also forwarded a copy of the patch to Frank Mandarino
<fmandarino@endrelia.com> for his comments.  He maintains the current
AT91 SSC & ALSA support.  <sound/soc/at91/>


> +/* SSC Receive Clock Mode Register */
> +#define SSC_RCMR			0x00000010
> +#define SSC_RCMR_CKG_SIZE			 2
> +#define SSC_RCMR_CKG_OFFSET			 6
> +#define SSC_RCMR_CKI_SIZE			 1
> +#define SSC_RCMR_CKI_OFFSET			 5
> +#define SSC_RCMR_CKO_SIZE			 3

I'm personally not a fan of the register & bit definition format the
AVR32 driver seem to use.
Can we not rather move the existing include/asm-arm/arch-at91/at91_ssc.h
to somewhere shared as atmel_ssc.h ?


Regards,
  Andrew Victor



  reply	other threads:[~2007-07-19  8:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-18 19:37 Hans-Christian Egtvedt
2007-07-19  8:29 ` Andrew Victor [this message]
2007-07-20  6:44   ` Hans-Christian Egtvedt
2007-07-20  6:55     ` Andrew Victor
2007-07-20 11:38       ` Hans-Christian Egtvedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1184833759.15007.33.camel@fuzzie.sanpeople.com \
    --to=andrew@sanpeople.com \
    --cc=david-b@pacbell.net \
    --cc=egtvedt@samfundet.no \
    --cc=hcegtvedt@atmel.com \
    --cc=kernel@avr32linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@rfo.atmel.com \
    --cc=patrice.vilchez@rfo.atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®