From: Daniel Walker <dwalker@mvista.com>
To: mingo@elte.hu
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: [PATCH -rt] temporary WARN_ON removal
Date: Sun, 22 Jul 2007 10:22:41 -0700 [thread overview]
Message-ID: <1185124961.2573.14.camel@imap.mvista.com> (raw)
These two WARN_ON calls send my system into a boot hang. They trigger
over and over , some examples below.
[ 58.438501] WARNING: at kernel/sched.c:3785 schedule()
[ 58.443444] [<c039b224>] schedule+0x74/0x110
[ 58.447772] [<c039a67f>] rest_init+0x4f/0x60
[ 58.452092] [<c0490a8f>] start_kernel+0x2cf/0x310
[ 58.456848] [<c0490210>] unknown_bootoption+0x0/0x250
[ 58.461951] =======================
[ 58.465496] WARNING: at kernel/sched.c:3683 schedule_debug()
[ 58.471118] [<c039ae0c>] __schedule+0x4cc/0x760
[ 58.475702] [<c010511a>] print_trace_address+0x1a/0x30
[ 58.480893] [<c0129a2b>] printk+0x1b/0x20
[ 58.484957] [<c01051f8>] show_trace_log_lvl+0x28/0x30
[ 58.490060] [<c039b1de>] schedule+0x2e/0x110
[ 58.494385] [<c039a67f>] rest_init+0x4f/0x60
[ 58.498709] [<c0490a8f>] start_kernel+0x2cf/0x310
[ 58.503465] [<c0490210>] unknown_bootoption+0x0/0x250
[ 58.508569] =======================
On closer inspection I'm not sure they are correctly placed. They could
trigger or not depending on when/if certain threads run.
Here is a patch to comment them out. This should go into the
preempt-realtime-sched.patch
Signed-Off-By: Daniel Walker <dwalker@mvista.com>
Index: linux-2.6.22.1/kernel/sched.c
===================================================================
--- linux-2.6.22.1.orig/kernel/sched.c 2007-07-22 17:18:38.000000000 +0000
+++ linux-2.6.22.1/kernel/sched.c 2007-07-22 17:17:48.000000000 +0000
@@ -3680,7 +3680,7 @@ static noinline void __schedule_bug(stru
*/
static inline void schedule_debug(struct task_struct *prev)
{
- WARN_ON(system_state == SYSTEM_BOOTING);
+ //WARN_ON(system_state == SYSTEM_BOOTING);
/*
* Test if we are atomic. Since do_exit() needs to call into
@@ -3782,7 +3782,7 @@ asmlinkage void __sched __schedule(void)
*/
asmlinkage void __sched schedule(void)
{
- WARN_ON(system_state == SYSTEM_BOOTING);
+ //WARN_ON(system_state == SYSTEM_BOOTING);
/*
* Test if we have interrupts disabled.
*/
next reply other threads:[~2007-07-22 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 17:22 Daniel Walker [this message]
2007-07-23 19:55 ` Ingo Molnar
2007-07-23 19:53 ` Daniel Walker
2007-07-30 18:01 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185124961.2573.14.camel@imap.mvista.com \
--to=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®