From: Suleiman Souhlal <ssouhlal@FreeBSD.org>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
Suleiman Souhlal <ssouhlal@FreeBSD.org>,
Suleiman Souhlal <suleiman@google.com>
Subject: [PATCH] Don't needlessly dirty mlocked pages when initially faulting them in.
Date: Thu, 26 Jul 2007 16:52:44 -0700 [thread overview]
Message-ID: <11854939641916-git-send-email-ssouhlal@FreeBSD.org> (raw)
make_pages_present() is dirtying mlocked pages if the VMA is writable, even
though it shouldn't, by telling get_user_pages() to simulate a write fault.
A simple way to test this is to mlock a multi-GB file, and then sync.
The sync will take a long time.
As far as I can see, it should be safe to just not simulate a write fault.
Signed-off-by: Suleiman Souhlal <suleiman@google.com>
---
mm/memory.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index f64cbf9..f43c9e8 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -2664,18 +2664,17 @@ #endif /* __PAGETABLE_PMD_FOLDED */
int make_pages_present(unsigned long addr, unsigned long end)
{
- int ret, len, write;
+ int ret, len;
struct vm_area_struct * vma;
vma = find_vma(current->mm, addr);
if (!vma)
return -1;
- write = (vma->vm_flags & VM_WRITE) != 0;
BUG_ON(addr >= end);
BUG_ON(end > vma->vm_end);
len = (end+PAGE_SIZE-1)/PAGE_SIZE-addr/PAGE_SIZE;
ret = get_user_pages(current, current->mm, addr,
- len, write, 0, NULL, NULL);
+ len, 0, 0, NULL, NULL);
if (ret < 0)
return ret;
return ret == len ? 0 : -1;
--
1.4.2
next reply other threads:[~2007-07-26 23:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 23:52 Suleiman Souhlal [this message]
2007-07-27 0:23 ` Andrew Morton
2007-07-27 6:33 ` Peter Zijlstra
2007-10-12 6:50 ` Suleiman Souhlal
2007-10-12 9:03 ` [PATCH] mm: avoid dirtying shared mappings on mlock Peter Zijlstra
2007-10-11 16:57 ` Nick Piggin
2007-10-11 17:07 ` Nick Piggin
2007-10-12 10:37 ` Peter Zijlstra
2007-10-11 18:14 ` Nick Piggin
2007-10-12 10:50 ` Peter Zijlstra
2007-10-12 12:23 ` Nick Piggin
2007-10-12 14:53 ` Arjan van de Ven
2007-10-12 14:58 ` Peter Zijlstra
2007-10-12 17:45 ` Suleiman Souhlal
2007-10-12 17:53 ` Arjan van de Ven
2007-10-12 18:02 ` Peter Zijlstra
2007-10-12 13:10 ` [PATCH] Don't needlessly dirty mlocked pages when initially faulting them in Mauro Giachero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11854939641916-git-send-email-ssouhlal@FreeBSD.org \
--to=ssouhlal@freebsd.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suleiman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®