From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB425C43381 for ; Mon, 1 Apr 2019 06:05:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C25422084B for ; Mon, 1 Apr 2019 06:05:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731447AbfDAGFE (ORCPT ); Mon, 1 Apr 2019 02:05:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59558 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbfDAGFD (ORCPT ); Mon, 1 Apr 2019 02:05:03 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 69C863084295; Mon, 1 Apr 2019 06:05:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5105C5D70D; Mon, 1 Apr 2019 06:05:03 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 13F611802120; Mon, 1 Apr 2019 06:05:03 +0000 (UTC) Date: Mon, 1 Apr 2019 02:05:02 -0400 (EDT) From: Pankaj Gupta To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Konstantin Khlebnikov , Andrew Morton , "Michael S . Tsirkin" , linux-mm@kvack.org Message-ID: <1185594000.16522589.1554098702713.JavaMail.zimbra@redhat.com> In-Reply-To: <20190329122649.28404-1-david@redhat.com> References: <20190329122649.28404-1-david@redhat.com> Subject: Re: [PATCH v1] mm: balloon: drop unused function stubs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.116.139, 10.4.195.22] Thread-Topic: balloon: drop unused function stubs Thread-Index: /cPl/4jQNeW9hdMwdinHmNF6zmc/7Q== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 01 Apr 2019 06:05:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > These are leftovers from the pre-"general non-lru movable page" era. > > Signed-off-by: David Hildenbrand > --- > include/linux/balloon_compaction.h | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/include/linux/balloon_compaction.h > b/include/linux/balloon_compaction.h > index f111c780ef1d..f31521dcb09a 100644 > --- a/include/linux/balloon_compaction.h > +++ b/include/linux/balloon_compaction.h > @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page > *page) > list_del(&page->lru); > } > > -static inline bool __is_movable_balloon_page(struct page *page) > -{ > - return false; > -} > - > -static inline bool balloon_page_movable(struct page *page) > -{ > - return false; > -} > - > -static inline bool isolated_balloon_page(struct page *page) > -{ > - return false; > -} > - > static inline bool balloon_page_isolate(struct page *page) > { > return false; > -- > 2.17.2 Looks good to me. Acked-by: Pankaj Gupta > >