From: Diego Woitasen <diego@woitasen.com.ar>
To: dm-devel@redhat.com
Cc: linux-kernel@vger.kernel.org, Diego Woitasen <diego@woitasen.com.ar>
Subject: [PATCH] remove unneded lock_kernel in drivers/md/dm.c and use unlocked_ioctl.
Date: Mon, 30 Jul 2007 23:23:49 -0300 [thread overview]
Message-ID: <11858486294133-git-send-email-diego@woitasen.com.ar> (raw)
Signed-off-by: Diego Woitasen <diego@woitasen.com.ar>
---
drivers/md/dm.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 141ff9f..aebb207 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -282,17 +282,16 @@ static int dm_blk_getgeo(struct block_device *bdev, struct hd_geometry *geo)
return dm_get_geometry(md, geo);
}
-static int dm_blk_ioctl(struct inode *inode, struct file *file,
- unsigned int cmd, unsigned long arg)
+static long dm_blk_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
{
struct mapped_device *md;
struct dm_table *map;
struct dm_target *tgt;
+ struct inode *inode;
int r = -ENOTTY;
- /* We don't really need this lock, but we do need 'inode'. */
- unlock_kernel();
+ inode = file->f_path.dentry->d_inode;
md = inode->i_bdev->bd_disk->private_data;
map = dm_get_table(md);
@@ -317,7 +316,6 @@ static int dm_blk_ioctl(struct inode *inode, struct file *file,
out:
dm_table_put(map);
- lock_kernel();
return r;
}
@@ -1550,7 +1548,7 @@ EXPORT_SYMBOL_GPL(dm_noflush_suspending);
static struct block_device_operations dm_blk_dops = {
.open = dm_blk_open,
.release = dm_blk_close,
- .ioctl = dm_blk_ioctl,
+ .unlocked_ioctl = dm_blk_ioctl,
.getgeo = dm_blk_getgeo,
.owner = THIS_MODULE
};
--
1.5.2.4
next reply other threads:[~2007-07-31 2:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 2:23 Diego Woitasen [this message]
2007-08-14 20:12 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11858486294133-git-send-email-diego@woitasen.com.ar \
--to=diego@woitasen.com.ar \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®