From: Johannes Berg <johannes@sipsolutions.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Andi Kleen <ak@suse.de>,
LKML <linux-kernel@vger.kernel.org>, Adrian Bunk <bunk@stusta.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: [linux-pm] Re: [Resend][PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION (updated)
Date: Mon, 06 Aug 2007 11:29:51 +0200 [thread overview]
Message-ID: <1186392591.28655.35.camel@johannes.berg> (raw)
In-Reply-To: <20070806090713.GC15329@atrey.karlin.mff.cuni.cz>
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
On Mon, 2007-08-06 at 11:07 +0200, Pavel Machek wrote:
> Hi!
>
> > +config SUSPEND_UP_POSSIBLE
> > + bool
> > + depends on (X86 && !X86_VOYAGER) || (PPC32 && PPC_MPC52xx) \
> > + || (PPC64 && (PPC_PSERIES || PPC_PMAC)) || ARM || BLACKFIN \
> > + || MIPS || SUPERH || FRV
> > + depends on !SMP
> > + default y
>
> I guess I'd rather left SUSPEND_UP_POSSIBLE to allways y (as it always
> was), and let architectures that can't handle it not return "mem"
> from list of valid states...
Yeah, that's the utterly broken interface we used to have. Until I fixed
it to have no valid states until architectures implement suspend_ops.
Still, I disagree, why bother with compiling code that can't ever be
used?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-08-06 9:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 17:06 Rafael J. Wysocki
2007-08-06 9:07 ` Pavel Machek
2007-08-06 9:29 ` Johannes Berg [this message]
2007-08-06 10:26 ` [linux-pm] " Pavel Machek
2007-08-06 11:15 ` Johannes Berg
2007-08-06 11:22 ` Johannes Berg
2007-08-06 11:36 ` Pavel Machek
2007-08-06 11:56 ` Rafael J. Wysocki
2007-08-07 9:42 ` Johannes Berg
2007-08-06 11:14 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186392591.28655.35.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®