mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] do not export /usr/include/scsi in make headers_install
Date: Sat, 11 Aug 2007 14:42:50 +0800	[thread overview]
Message-ID: <1186814570.3169.4.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20070806130210.GA2239@suse.de>

On Mon, 2007-08-06 at 15:02 +0200, Olaf Hering wrote:
> On Mon, Aug 06, Christoph Hellwig wrote:
> 
> > On Mon, Aug 06, 2007 at 02:45:46PM +0200, Olaf Hering wrote:
> > > 
> > > glibc and make headers_install_all provide /usr/include/scsi
> > > One of them has to go.
> > > 
> > > A quick diff shows no differences, expect:
> > 
> > ..
> > 
> > > Which copy should be provided by a distributor?
> > 
> > The glibc one of course.  The kernel scsi.h should never have been
> > added to the list of exportable headers.  
> 
> /usr/include/scsi is provided by glibc.
> Remove the scsi export from make headers_install target.
> 
> 
> Signed-off-by: Olaf Hering <olh@suse.de>

Acked-by: David Woodhouse <dwmw2@infradead.org>

> ---
>  include/Kbuild      |    1 -
>  include/scsi/Kbuild |    4 ----
>  2 files changed, 5 deletions(-)
> 
> --- a/include/Kbuild
> +++ b/include/Kbuild
> @@ -1,6 +1,5 @@
>  header-y += asm-generic/
>  header-y += linux/
> -header-y += scsi/
>  header-y += sound/
>  header-y += mtd/
>  header-y += rdma/
> --- a/include/scsi/Kbuild
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -header-y += scsi.h
> -
> -unifdef-y += scsi_ioctl.h
> -unifdef-y += sg.h
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-- 
dwmw2


      reply	other threads:[~2007-08-11  6:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-06 12:45 glibc and make headers_install_all provide /usr/include/scsi Olaf Hering
2007-08-06 12:52 ` Christoph Hellwig
2007-08-06 13:02   ` [PATCH] do not export /usr/include/scsi in make headers_install Olaf Hering
2007-08-11  6:42     ` David Woodhouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1186814570.3169.4.camel@shinybook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=olh@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®