From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755457AbdKBJqJ (ORCPT ); Thu, 2 Nov 2017 05:46:09 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:51684 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbdKBJqG (ORCPT ); Thu, 2 Nov 2017 05:46:06 -0400 X-Google-Smtp-Source: ABhQp+TUiYFYafPg+00cbj99XNZA5dFnJ7A64r8eKB1v8oDiTHOWtft3Bp8M42eSKH5COmS3CVKG2Q== Reply-To: christian.koenig@amd.com Subject: Re: [PATCH] dma-buf: Cleanup comments on dma_buf_map_attachment() To: Liviu Dudau , Sumit Semwal Cc: LKML , DRI-devel , Linux Media ML References: <20171101140630.2884-1-Liviu.Dudau@arm.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <118709d7-07f7-7d81-4861-6cbff81e5ba7@gmail.com> Date: Thu, 2 Nov 2017 10:45:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171101140630.2884-1-Liviu.Dudau@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 01.11.2017 um 15:06 schrieb Liviu Dudau: > Mappings need to be unmapped by calling dma_buf_unmap_attachment() and > not by calling again dma_buf_map_attachment(). Also fix some spelling > mistakes. > > Signed-off-by: Liviu Dudau Reviewed-by: Christian König > --- > drivers/dma-buf/dma-buf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index bc1cb284111cb..1792385405f0e 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -351,13 +351,13 @@ static inline int is_dma_buf_file(struct file *file) > * > * 2. Userspace passes this file-descriptors to all drivers it wants this buffer > * to share with: First the filedescriptor is converted to a &dma_buf using > - * dma_buf_get(). The the buffer is attached to the device using > + * dma_buf_get(). Then the buffer is attached to the device using > * dma_buf_attach(). > * > * Up to this stage the exporter is still free to migrate or reallocate the > * backing storage. > * > - * 3. Once the buffer is attached to all devices userspace can inniate DMA > + * 3. Once the buffer is attached to all devices userspace can initiate DMA > * access to the shared buffer. In the kernel this is done by calling > * dma_buf_map_attachment() and dma_buf_unmap_attachment(). > * > @@ -617,7 +617,7 @@ EXPORT_SYMBOL_GPL(dma_buf_detach); > * Returns sg_table containing the scatterlist to be returned; returns ERR_PTR > * on error. May return -EINTR if it is interrupted by a signal. > * > - * A mapping must be unmapped again using dma_buf_map_attachment(). Note that > + * A mapping must be unmapped by using dma_buf_unmap_attachment(). Note that > * the underlying backing storage is pinned for as long as a mapping exists, > * therefore users/importers should not hold onto a mapping for undue amounts of > * time.