From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
RT <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
john stultz <johnstul@us.ibm.com>
Subject: [PATCH RT 2/3] initialize the clock source to jiffies clock.
Date: Fri, 24 Aug 2007 13:57:14 -0400 [thread overview]
Message-ID: <1187978234.2941.18.camel@localhost.localdomain> (raw)
The latency tracer can call clocksource_read very early in bootup and
before the clock source variable has been initialized. This results in a
crash at boot up (even before earlyprintk is initialized). Since the
clock->read variable is points to NULL.
This patch simply initializes the clock to use clocksource_jiffies, so
that any early user of clocksource_read will not crash.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Index: linux-2.6-rt/kernel/time/timekeeping.c
===================================================================
--- linux-2.6-rt.orig/kernel/time/timekeeping.c 2007-08-24 11:38:11.000000000 -0400
+++ linux-2.6-rt/kernel/time/timekeeping.c 2007-08-24 13:41:03.000000000 -0400
@@ -43,7 +43,15 @@ struct timespec wall_to_monotonic __attr
EXPORT_SYMBOL(xtime);
-static struct clocksource *clock; /* pointer to current clocksource */
+extern struct clocksource clocksource_jiffies;
+
+/*
+ * pointer to current clocksource
+ * Just in case we use clocksource_read before we initialize
+ * the actual clock source. Instead of calling a NULL read pointer
+ * we return jiffies.
+ */
+static struct clocksource *clock = &clocksource_jiffies;
#ifdef CONFIG_GENERIC_TIME
reply other threads:[~2007-08-24 17:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187978234.2941.18.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®