From: Paolo Abeni <pabeni@redhat.com>
To: Kaifeng Wang <kaifengw@google.com>, netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, almasrymina@google.com,
edumazet@google.com, willemb@google.com, davem@davemloft.net,
kuba@kernel.org, horms@kernel.org, sdf@fomichev.me,
bobbyeshleman@meta.com, kaiyuanz@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: devmem: check uid and netns in net_devmem_get_binding()
Date: Mon, 12 Oct 2026 18:00:40 +0200 [thread overview]
Message-ID: <11889de6-54af-4dd7-8902-01e4a5bf97f2@redhat.com> (raw)
In-Reply-To: <833b5ef9-eda9-4c15-85cd-29202e0f87ca@redhat.com>
On 10/12/26 15:48, Paolo Abeni wrote:
> On 10/8/26 23:40, Kaifeng Wang wrote:
>>> Could this break existing devmem TX users whose TCP socket and netlink
>>> socket have different owners?
>>
>> This restriction is intentional. NETDEV_CMD_BIND_TX was made
>> unprivileged specifically so that an application can bind its own
>> dmabuf directly and transmit on its own sockets without needing a
>> separate privileged helper process. As noted in the comment above
>> netdev_nl_bind_tx_doit(), bind-tx is meant for the caller to transmit
>> "on their own sockets". We are not aware of any userspace workloads
>> that split bind-tx and TCP socket creation across different UIDs or
>> network namespaces.
> Still there is slight possibility of breaking some weird setup, so
> I'm going to apply this one to net-next.
Applied to net-next, thanks!
/P
prev parent reply other threads:[~2026-10-12 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 21:04 Kaifeng Wang
2026-10-05 21:09 ` netdev-bot+sinfo
2026-10-05 21:22 ` Kaifeng Wang
2026-10-05 22:24 ` Stanislav Fomichev
2026-10-06 16:19 ` Bobby Eshleman
2026-10-08 0:04 ` netdev-bot+sashiko
2026-10-08 21:40 ` Kaifeng Wang
2026-10-12 13:48 ` Paolo Abeni
2026-10-12 16:00 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11889de6-54af-4dd7-8902-01e4a5bf97f2@redhat.com \
--to=pabeni@redhat.com \
--cc=almasrymina@google.com \
--cc=bobbyeshleman@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kaifengw@google.com \
--cc=kaiyuanz@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®