From: Johannes Berg <johannes@sipsolutions.net>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Randy Dunlap <randy.dunlap@oracle.com>,
Pavel Emelianov <xemul@openvz.org>,
Zach Brown <zach.brown@oracle.com>, Dave Jones <davej@redhat.com>,
Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: [PATCH] list.h: add list_for_each_entry_continue_rcu
Date: Fri, 07 Sep 2007 21:09:52 +0200 [thread overview]
Message-ID: <1189192192.28781.182.camel@johannes.berg> (raw)
In-Reply-To: <20070907153453.GD8864@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Fri, 2007-09-07 at 08:34 -0700, Paul E. McKenney wrote:
> > + * Continue to iterate over rcu list of given type, continuing after
> > + * the current position.
>
> Please add something like the following to this comment:
>
> Note that the caller is responsible for making sure that
> the element remains in place between the earlier iterator
> and this one. One way to do this is to ensure that
> both iterators are covered by the same rcu_read_lock(),
> while others involve reference counts, flags, or mutexes.
Sure, will do. Should this comment also be added to
list_for_each_continue_rcu()?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-09-07 19:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 14:34 Johannes Berg
2007-09-07 15:34 ` Paul E. McKenney
2007-09-07 19:09 ` Johannes Berg [this message]
2007-09-07 19:57 ` Paul E. McKenney
2007-09-07 20:04 ` Johannes Berg
2007-09-10 12:05 Johannes Berg
2007-09-10 17:39 ` Paul E. McKenney
2007-09-14 21:14 ` Johannes Berg
2007-09-14 21:52 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189192192.28781.182.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=davej@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=paulmck@linux.vnet.ibm.com \
--cc=randy.dunlap@oracle.com \
--cc=xemul@openvz.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®