mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: bwalle@suse.de, linux-kernel@vger.kernel.org
Subject: Re: build #286 failed for 2.6.23-rc6-g0d4cbb5 in linux/arch/i386/mach-voyager/setup.c
Date: Tue, 11 Sep 2007 09:30:15 -0500	[thread overview]
Message-ID: <1189521015.5351.11.camel@localhost.localdomain> (raw)
In-Reply-To: <200709111621.39060.toralf.foerster@gmx.de>

On Tue, 2007-09-11 at 16:21 +0200, Toralf Förster wrote:
> Hello,
> 
> the build with the attached .config failed, make ends with:
> ...
>   CC      arch/i386/mm/highmem.o
>   LD      arch/i386/mm/built-in.o
>   CC      arch/i386/mach-voyager/setup.o
> arch/i386/mach-voyager/setup.c: In function 'time_init_hook':
> arch/i386/mach-voyager/setup.c:52: error: implicit declaration of function 'safe_smp_processor_id'

This should be a warning, not an error

> make[1]: *** [arch/i386/mach-voyager/setup.o] Error 1
> make: *** [arch/i386/mach-voyager] Error 2

> The build was made with an old .config from kernel 2.6.22-rc3
> (where the build also failed) :
> $> make mrproper && cp <oldconfig> .config && make oldconfig && make
> 
> Here's the config:
[...]
> # CONFIG_SMP is not set

This is the problem ... it's a known one on voyager.  This will prevent
the config being selected by the random config generator.

James

diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
index 97b64d7..cca3b90 100644
--- a/arch/i386/Kconfig
+++ b/arch/i386/Kconfig
@@ -146,6 +146,7 @@ config X86_ELAN
 
 config X86_VOYAGER
 	bool "Voyager (NCR)"
+	select SMP if !BROKEN
 	help
 	  Voyager is an MCA-based 32-way capable SMP architecture proprietary
 	  to NCR Corp.  Machine classes 345x/35xx/4100/51xx are Voyager-based.



  reply	other threads:[~2007-09-11 14:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-11 14:21 Toralf Förster
2007-09-11 14:30 ` James Bottomley [this message]
2007-09-11 16:51   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1189521015.5351.11.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=bwalle@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®