From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751723AbdALNPU (ORCPT <rfc822;w@1wt.eu>);
        Thu, 12 Jan 2017 08:15:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39650 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751508AbdALNPN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Jan 2017 08:15:13 -0500
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <1481907033.17553.78.camel@linux.vnet.ibm.com>
References: <1481907033.17553.78.camel@linux.vnet.ibm.com> <20161216090827.GA7285@elgon.mountain>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: dhowells@redhat.com, Dan Carpenter <dan.carpenter@oracle.com>,
        David Safford <safford@us.ibm.com>,
        James Morris <james.l.morris@oracle.com>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] KEYS: Fix an error code in request_master_key()
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11898.1484226513.1@warthog.procyon.org.uk>
Date: Thu, 12 Jan 2017 13:08:33 +0000
Message-ID: <11899.1484226513@warthog.procyon.org.uk>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 12 Jan 2017 13:08:37 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:

> On Fri, 2016-12-16 at 12:08 +0300, Dan Carpenter wrote:
> > This function has two callers and neither are able to handle a NULL
> > return.  Really, -EINVAL is the correct thing return here anyway.  This
> > fixes some static checker warnings like:
> > 
> > 	security/keys/encrypted-keys/encrypted.c:709 encrypted_key_decrypt()
> > 	error: uninitialized symbol 'master_key'.
> > 
> > Fixes: 7e70cb497850 ("keys: add new key-type encrypted")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Thanks!

Can I put that down as an Acked-by or Reviewed-by?

David